Bug 313431
| Summary: | Review Request: fedorainfinity-kdm-theme - Fedora Infinity KDM theme | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Kevin Kofler <kevin> |
| Component: | Package Review | Assignee: | Rex Dieter <rdieter> |
| Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | duffy, fedora, fedora-package-review, katzj, mclasen, notting, rdieter, rstrode, than |
| Target Milestone: | --- | Flags: | rdieter:
fedora-review+
kevin: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2007-10-11 16:02:02 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 314041 | ||
|
Description
Kevin Kofler
2007-10-01 01:24:56 UTC
I'll take this. A few picky SHOULDS: 1. using %find_lang. I don't see any included translations, so I'd suggest removing the extra bloat wrt %find_lang. 2. use %defattr(-, root, root, -) and MUST: 3. License: GPLv2 but missing %doc COPYING Otherwise, it's simple/clean, fix at item #3 (I'll trust you to do that). APPROVED. Oh, and it looks real nice btw. :) The theme doesn't use a logo, yea? Probably don't need the system-logos Requires. Also, might be good to talk to jeremy about getting this put on http://git.fedoraproject.org/ with the other themes. > 1. using %find_lang. I don't see any included translations, so I'd suggest > removing the extra bloat wrt %find_lang. That one was lifted from the fedorainfinity-gdm-theme specfile (which I used as the template), maybe the %find_lang should be removed there too? > The theme doesn't use a logo, yea? Probably don't need the system-logos > Requires. Shouldn't the Requires go away in fedorainfinity-gdm-theme too then? I'm also going to go ahead and put GPL+ into the License tag because that's what the GDM theme now has and I sure don't care about what version of the GPL my changes are used under. New Package CVS Request ======================= Package Name: fedorainfinity-kdm-theme Short Description: Fedora Infinity KDM theme Owners: kkofler,rdieter,than Branches: InitialCC: Cvsextras Commits: no (Oops, actually putting in a valid CVS request this time. I accidentally set the flag and then commented about other stuff.) Just for reference, this is what I intend to commit: Spec URL: http://repo.calcforge.org/f8/fedorainfinity-kdm-theme.spec SRPM URL: http://repo.calcforge.org/f8/fedorainfinity-kdm-theme-1.0.0-2.fc7.src.rpm - Change License tag to GPL+ as for the GDM theme - Drop unneeded Requires: system-logos - Pass all 4 arguments to %%defattr - Drop unneeded %%find_lang as there are no translations anyway - Add COPYING as %%doc Hmmm, is it actually OK to label this, the GDM theme it's based on and all the other redhat-artwork splitoffs as GPL+? The GPL says if there's a reference to "GNU General Public License" without a version specified, then any version can be chosen, but here the only reference to the GPL is the included copy of the GPLv2, so what actually applies here? Mo, what license is Fedora Infinity under? Is it based on another theme? ping, cvsadmins (see comment #8 )? Been a couple of days now, kde spin needs this. Sorry for the delay. cvs done. Hey Kevin, Can you add an Obsoletes: redhat-artwork-kde to this package? Yes, I'll do that. It's not ideal because this will also remove stuff like Bluecurve which will have to be reinstalled by hand if the users want it, but that's the nature of package splits. Obsoletes: redhat-artwork-kde added in fedorainfinity-kdm-theme-1.0.0-3.fc8, built for dist-f8. |