Bug 313461
Summary: | Review Request: astromenace - Hardcore 3D space shooter with spaceship upgrade possibilities | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Gwyn Ciesla <gwync> | ||||||||
Component: | Package Review | Assignee: | Hans de Goede <hdegoede> | ||||||||
Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||||||
Severity: | medium | Docs Contact: | |||||||||
Priority: | medium | ||||||||||
Version: | rawhide | CC: | fedora, fedora-package-review, hdegoede, lam, notting | ||||||||
Target Milestone: | --- | Flags: | hdegoede:
fedora-review+
kevin: fedora-cvs+ |
||||||||
Target Release: | --- | ||||||||||
Hardware: | All | ||||||||||
OS: | Linux | ||||||||||
Whiteboard: | |||||||||||
Fixed In Version: | 1.2-3.fc7 | Doc Type: | Bug Fix | ||||||||
Doc Text: | Story Points: | --- | |||||||||
Clone Of: | Environment: | ||||||||||
Last Closed: | 2007-10-10 19:34:03 UTC | Type: | --- | ||||||||
Regression: | --- | Mount Type: | --- | ||||||||
Documentation: | --- | CRM: | |||||||||
Verified Versions: | Category: | --- | |||||||||
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||||||
Cloudforms Team: | --- | Target Upstream Version: | |||||||||
Embargoed: | |||||||||||
Attachments: |
|
Description
Gwyn Ciesla
2007-10-01 02:39:55 UTC
IMO, you should consider placing the data files in a seperate -data package to help reduce large update downloads. (In reply to comment #1) > IMO, you should consider placing the data files in a seperate -data package to > help reduce large update downloads. Since the data files are already in a seperate tarbal upstream, I will even go as far as to say that you *must* put them in a seperate srpm. Then if we do bug / packaging fixes to the code the user doesn't need to redownload all the data again. Also I think you should package the other languages too (make all languages part of the data srpm please). Spec URL: http://zanoni.jcomserv.net/fedora/AstroMenace/AstroMenace.spec SRPM URL: http://zanoni.jcomserv.net/fedora/AstroMenace/AstroMenace-1.2.0-2.fc7.src.rpm data package review:https://bugzilla.redhat.com/show_bug.cgi?id=315481 What you're packaging is not exactly AstroMenace. You're packaging a fork based of an open portion of AstroMenace and that fork is called OpenAstroManace. Either package real AM (newer version is available already, without GAME_VERSION_ID/BUILD change, but with many code cleanups/changes), or change package name appropriately. I'm aware that at the moment both games don't differ (most changes in AM look to fix build warnings), but time will tell if the fork is successful. BTW, wasn't there a tendency to change package names to lower case (SysVinit->sysvinit and some others)? Even if not, both upstreams use low-case file names. Based on the timing of the announcement on f-g-l and the dates on the sf.net files, I assumed the sf.net project was owned by Viewizard. If this is not the case, I can easily change sources to Viewizard's upstream. The only reason I went with sf.net was because I figured that way if something happened to Viewizard, I could keep the same URLs. I'd actually be happier using the Viewizard upstream, if for no other reason than to reward them for good behaviour in GPLing AstroMenace. I can also change to all lc. Opinions from the cc: gallery? :) I agree that using viewwizard as upstream is better then using then openastromenace sf.net project, using all lc also gets a +1 from me. Ok, I'll get on that. FWIW, I don't see anything more recent than 1.2 on the Viewizrd site, and that's what oamenace is at. Spec URL: http://zanoni.jcomserv.net/fedora/astromenace/astromenace.spec SRPM URL: http://zanoni.jcomserv.net/fedora/astromenace/astromenace-1.2-1.fc7.src.rpm Addressed, main and data. Of course, now it doesn't work: [limb@fawkes ~]$ astromenace --noAA --dir=/usr/share/astromenace/ AstroMenace 1.2 70914 VFS file was opened /usr/share/astromenace/gamedata.vfs Can't find VFS file /usr/share/astromenace/gamelang.vfs gamelang.vfs file not found or corrupted. There is no gamelang.vfs, but there wasn't in oamenace either and it worked. Jon, Any luck on getting the official Astromenace to run, iow any luck on getting past the error from comment #9? Need help? I think if I patch Main.cpp to match Main.cpp from the fork, it'll work, because I found where it's more permissive than the official version. Problem is, I'm having trouble generating a patch, as the official Main.cpp has tons of odd characters. Any thoughts? Probably some kind of encoding problem, if you can attach them both to this bug I'll take a look. Created attachment 217681 [details]
Original Main.cpp
Created attachment 217691 [details]
openastromenace fork Main.cpp
There you are. I could probably just use the forked version of this file only, but I'd rather patch. Just opened them elsewhere. That looks like Cyrillic. Created attachment 217761 [details]
Patch bringing in the changes from the fork into the orig main.cpp
I could generate a diff between the 2 just fine. Indeed they contain Cyrillic
(probably Russian, seeing how there is a Russian translation) comments, but
thats not the problem. The original one contains CRLF line endings for some
lines, and normal LF only line endings on other, where as the fork only ahs the
normal line endings. I've hand edited the diff to make it smaller, removing any
changes resulting from the line ending differences.
You may need to change these lines:
--- Main.orig.cpp 2007-10-05 19:30:17.000000000 +0200
+++ Main.fork.cpp 2007-10-05 19:32:55.000000000 +0200
To something like:
--- Astromenace-version/src/Main.orig.cpp 2007-10-05 19:30:17.000000000
+0200
+++ Astromenace-version/src/Main.fork.cpp 2007-10-05 19:32:55.000000000
+0200
So that you can use %patch -p1 as is normal. Note I gzipped the diff to make
sure bugzilla doesn't mess with the line endings.
I got it. Turns out the problem was PuTTY. Now that I'm using Gnome-terminal/FreeNX, it's displaying correctly. I'll try applying it and let you know what I find. Thanks. :) Spec URL: http://zanoni.jcomserv.net/fedora/astromenace/astromenace.spec SRPM URL: http://zanoni.jcomserv.net/fedora/astromenace/astromenace-1.2-2.fc7.src.rpm Patch applied, and it works. Full review done (sources match upstream, license ok, everything else ok), a couple of Should Fix's, but no blockers, so its approved! Should Fix: -Please always start the Name with a capital in the .desktop file, so: Name=Astromenace -Please use opengl-games-utils wrapper to check for missing DRI Add: "Requires: opengl-games-utils" Add to %install: "ln -s opengl-game-wrapper.sh $RPM_BUILD_ROOT%{_bindir}/%{name}-wrapper" Add "%{_bindir}/%{name}-wrapper" to files Change the .desktop file Exec entry from "%{name}" to "%{name}-wrapper" -Once build please add this to the games-live .ks file: http://fedoraproject.org/wiki/SIGs/Games/GamesLive -Please change the default resolution to 640x480 (it defaulted to my desktop resolution). With my desktop resolution its unplayable with my somewhat under powered 3d card (intel 965) on 640x480 it rocks on at 15 fps! Thanks! Shoulds addressed. New Package CVS Request ======================= Package Name: astromenace Short Description: Hardcore 3D space shooter with spaceship upgrade possibilities Owners: limb Branches: FC-6 F-7 InitialCC: Cvsextras Commits: yes cvs done. astromenace-1.2-3.fc7 has been pushed to the Fedora 7 stable repository. If problems still persist, please make note of it in this bug report. |