Bug 3141

Summary: Patch for mount line counting for error report
Product: [Retired] Red Hat Linux Reporter: tom.vijlbrief
Component: mountAssignee: David Lawrence <dkl>
Severity: medium Docs Contact:
Priority: medium    
Version: 5.2   
Target Milestone: ---   
Target Release: ---   
Hardware: i386   
OS: Linux   
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 1999-05-31 16:13:05 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:

Description tom.vijlbrief 1999-05-29 13:17:41 UTC
Mount (2.8a from redhat 5.2)
always reports lineno 0 for errors in an fstab:

To reproduce:

Damage the /etc/fstab for e.g. /mnt/floppy by adding an
aditional nonsense field before the options, the try to

prompt> mount /mnt/floppy
[mntent]: line 0 in /etc/fstab is bad
mount: can't find /mnt/floppy in /etc/mtab or /etc/fstab

After applying this one line patch the correct lineno is

prompt> mount /mnt/floppy
[mntent]: line 7 in /etc/fstab is bad
mount: can't find /mnt/floppy in /etc/mtab or /etc/fstab

====patch follows:===========
*** mntent.c.old        Sat May 29 12:51:22 1999
--- mntent.c    Sat May 29 12:51:14 1999
*** 148,157 ****
--- 148,158 ----

        /* read the next non-blank non-comment line */
        do {
                if (fgets (buf, sizeof(buf), mfp->mntent_fp)
== NULL)
                        return NULL;
+               mfp->mntent_lineno++;

                s = index (buf, '\n');
                if (s == NULL) {
                        /* extremely long line - assume file
was corrupted */
                        mfp->mntent_errs = 1;

Comment 1 Jeff Johnson 1999-05-31 16:13:59 UTC
This is fixed in util-linux-2.9o.