Bug 322101

Description of problem:
The ypbind service is not starting, due to the fact that the ypbind init.d
script is checking for ypbind being registered with rpcbind too quickly after
starting it.

Here's the offending section of the script: numbers at the start of the line
refer to the analysis below:
----------------------------
  echo -n $"Starting NIS service: "
	selinux_on
[1]	daemon ypbind $OTHER_YPBIND_OPTS
	RETVAL=$?
	echo
	if [ $RETVAL -ne 0 ]; then
	    selinux_off
	    logger -t ypbind "failed to start!"
	    return $RETVAL
	fi
	echo -n $"Binding NIS service: "
	# the following fixes problems with the init scripts continuing
	# even when we are really not bound yet to a server, and then things
	# that need NIS fail.
	timeout=$NISTIMEOUT
	while [ $timeout -gt 0 ]; do
[2]	    /usr/sbin/rpcinfo -p | LC_ALL=C fgrep -q ypbind && \
			/usr/bin/ypwhich > /dev/null 2>&1
	    RETVAL=$?
	    if [ $RETVAL -eq 0 ]; then
		break;
	    fi
	    echo -n "..."
	    # ypwhich has a hardcode 15sec timeout
	    # so subtract that from NISTIMEOUT to
	    # to see of we should continue to wait
[3]	    timeout=`expr $timeout - 15` 
	done
-------------
[1] ypbind is started as a daemon at this point, so the script will continue
past this point. At that instant, ypbind is not yet registered with rpcbind

[2] If ypbind is NOT yet registered with rpcbind, the first part of the "&"
condition will fail, and the ypwhich will NOT be executed.

[3] The script *assumes* that the ypwhich call will delay 15 seconds, but since
it was not executed, no delay occurs, and the loop will immediately continue.

As a result, the (default 3) iterations of the loop which are supposed to take
45 seconds happen pretty much instantaneously and the loop terminates. The
script then assumes that the ypbind daemon isn't running properly and kills it.

The simple and stupid solution is to put a "sleep 1" before the loop, to give
ypbind plenty of time to start and register with rpcbind. The better solution
would be to split the check of rpcbind and the ypwhich into 2 lines, and in the
case that rpcbind fails to show ypbind then delay and try again - however, this
will *still* cause the start-up to be delayed by 1 second in the failure case.
Even better would be to really check the elapsed time rather than assuming the
15 second timeout, and actually wait the specified time - this might be done by
starting a "sleep 45" as a backgrounded command and looking for it to terminate.


Version-Release number of selected component (if applicable):
ypbind-1.20.4-2.fc8

How reproducible:
Every time

Steps to Reproduce:
1. service ypbind restart or service ypbind start
  
Actual results:
ypbind starts and then is killed by the startup script. (see discussion)

Expected results:
ypbind runs

Additional info: