Bug 32246
| Summary: | Do not ignore "bad" lines in dac960 current_status proc entry | ||
|---|---|---|---|
| Product: | [Retired] Red Hat Linux | Reporter: | Joshua M. Thompson <joshua.thompson> |
| Component: | anaconda | Assignee: | Michael Fulbright <msf> |
| Status: | CLOSED RAWHIDE | QA Contact: | Brock Organ <borgan> |
| Severity: | high | Docs Contact: | |
| Priority: | medium | ||
| Version: | 7.0 | ||
| Target Milestone: | --- | ||
| Target Release: | --- | ||
| Hardware: | i386 | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2001-03-22 16:03:42 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Joshua M. Thompson
2001-03-19 18:01:37 UTC
Using a boot disk I managed to boot up and take a look at what was left by the installer. The install log shows nothing past the installation of zsh. The /etc/fstab file does not exist yet either so it seems like it's dying fairly early in the post-install code in todo.py. cpyExtraModules() seems like a likely candidate since I am using a driver disk. It turns out this bug only occurs if the Mylex card is actually rebuilding the array when the install is started. The problem is in the isys module. In isys/probe.c the function dac960GetDevices tries to walk through the current_status proc file for each installed array and look for lines containing the string "/dev/rd/". It then takes everything between the start of that string and the next colon and makes that the device name. Problem is, in my specific case the end of the file contains the line "Logical Drive 0 (/dev/rd/c0d0) Background Initialization Completed". Needless to say there's no colon there so the code ends up trying to dereference a null pointer (lines 445 and 446). So would a fix be to ignore lines which start with /dev/rd but do not contain a ":"? I do not have a card here to examine the contents of the current_status file, so your help is greatly appreciated. Yes that should solve the problem. This one-line patch sould solve the problem:
--- anaconda-7.0.1.orig/isys/probe.c Mon Aug 14 15:54:24 2000
+++ anaconda-7.0.1/isys/probe.c Wed Mar 21 14:51:29 2001
@@ -441,6 +441,7 @@
while (start && (start = strstr(start, "/dev/rd/"))) {
start += 5;
chptr = strchr(start, ':');
+ if (!chptr) continue;
*chptr = '\0';
if (!deviceKnown(devices, start)) {
Patch applied, thank you! |