Bug 326871

Summary: zynaddsubfx improper blocking call in Jack process function
Product: [Fedora] Fedora Reporter: Fernando Lopez-Lezcano <nando>
Component: zynaddsubfxAssignee: Anthony Green <green>
Status: CLOSED NEXTRELEASE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: high Docs Contact:
Priority: medium    
Version: rawhide   
Target Milestone: ---   
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2007-10-10 21:36:50 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
unzombify patch
none
spec file changes none

Description Fernando Lopez-Lezcano 2007-10-10 19:41:19 UTC 
Description of problem:

ZynAddSubFX was not very well designed to work with the Jack audio server, the
jack process call can block on a mutex (it should not) and then the jack client
delays processing the whole jack graph. This patch by Lars Luthman avoids the
problem and zynaddsubfx becomes a lot more reliable, specially with the current
version of svn jack which is much more sensitive to hiccups in the clients. 

Version-Release number of selected component (if applicable):
Current version is 2.2.1-14.fcx

How reproducible:
Always

Steps to Reproduce:
1. For example, change the current patch, you should observe a glitch in the
Jack output. If the glitch is long enough ZynAddSubFX gets kicked out of the
Jack processing graph. 
  
Actual results:
Xruns in the Jack audio server

Expected results:
No xruns in the Jack audio server

Additional info:
Patch originally by Lars Luthman, tweaked to patch on zyn with no preexisting
Jack midi patches.

Attached files: zynaddsubfx-unzombify.patch
Comment 1 Fernando Lopez-Lezcano 2007-10-10 19:41:19 UTC 
Created attachment 223291 [details]
unzombify patch
Comment 2 Fernando Lopez-Lezcano 2007-10-10 19:42:08 UTC 
Created attachment 223301 [details]
spec file changes
Comment 3 Anthony Green 2007-10-10 20:25:42 UTC 
Thanks.  I agree that ZynAddSubFX has problems in this area.    I looked into it
about a year ago with an eye to have it use lockless buffers.   I'll push out a
new zyn for devel, F7 and FC-6.
Comment 4 Fernando Lopez-Lezcano 2007-10-10 20:30:35 UTC 
(In reply to comment #3)
> Thanks.  I agree that ZynAddSubFX has problems in this area.    I looked into it
> about a year ago with an eye to have it use lockless buffers.   I'll push out a
> new zyn for devel, F7 and FC-6.

Thanks! Obviously it'd be good to have a proper fix but this patch improves the
situation a lot. I'm testing a new svn jack and zyn without this is not really
usable.
Comment 5 Anthony Green 2007-10-10 21:36:50 UTC 
I've kicked off builds for FE-6, F-7 and devel.  The next updates should include
this patch.  I'm closing this bug.  Thanks nando!