Bug 328781
| Summary: | Review Request: gegl - A graph based image processing framework | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Deji Akingunola <dakingun> |
| Component: | Package Review | Assignee: | Patrice Dumas <pertusus> |
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | fedora-package-review, notting, pertusus |
| Target Milestone: | --- | Flags: | pertusus:
fedora-review+
wtogami: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2007-11-13 06:19:29 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | 328771 | ||
| Bug Blocks: | |||
|
Description
Deji Akingunola
2007-10-12 00:56:26 UTC
Modified the spec not to point to an inexistent source url. Spec URL: ftp://czar.eas.yorku.ca/pub/gegl/gegl.spec SRPM URL: ftp://czar.eas.yorku.ca/pub/gegl/gegl-0.0.13-0.2.20071011svn.fc8.src.rpm With a couple of fixes; Spec URL: ftp://czar.eas.yorku.ca/pub/gegl/gegl.spec SRPM URL: ftp://czar.eas.yorku.ca/pub/gegl/gegl-0.0.13-0.3.20071011svn.fc8.src.rpm Updated the license field, Spec URL: ftp://czar.eas.yorku.ca/pub/gegl/gegl.spec SRPM URL: ftp://czar.eas.yorku.ca/pub/gegl/gegl-0.0.13-0.4.20071011svn.fc8.src.rpm * doesn't configure accepts --disable-static? If yes I think it is
better than removing *.a after the build.
* %{_includedir}/gegl-1.0/ seems unowned
Yes, configure accepts --disable-static, using it now. Have also fix the directory ownership. Thanks. Spec URL: ftp://czar.eas.yorku.ca/pub/gegl/gegl.spec SRPM URL: ftp://czar.eas.yorku.ca/pub/gegl/gegl-0.0.13-0.5.20071011svn.fc8.src.rpm The docs should be shipped. 2 relevant rpmlint warnings gegl-debuginfo.i386: W: spurious-executable-perm /usr/src/debug/gegl-svn20071011/operations/render/perlin/perlin.c gegl-debuginfo.i386: W: spurious-executable-perm /usr/src/debug/gegl-svn20071011/operations/io/ff-load.c the BuildRequires should certainly be graphviz and not graphviz-devel (In reply to comment #6) > The docs should be shipped. > There's a currently a problem (upstream) with generating the docs, that they have added a default configure option to disable building the doc until the issue is resolved. I can't take on the responsibility of fixing it now. > 2 relevant rpmlint warnings > gegl-debuginfo.i386: W: spurious-executable-perm > /usr/src/debug/gegl-svn20071011/operations/render/perlin/perlin.c > gegl-debuginfo.i386: W: spurious-executable-perm > /usr/src/debug/gegl-svn20071011/operations/io/ff-load.c > > the BuildRequires should certainly be graphviz and not > graphviz-devel I'll check up the last 2 issues. I've fixed the graphiz BR and the gegl-debuginfo rpmlint warnings. New pacakges below; Spec URL: ftp://czar.eas.yorku.ca/pub/gegl/gegl.spec SRPM URL: ftp://czar.eas.yorku.ca/pub/gegl/gegl-0.0.13-0.6.20071011svn.fc8.src.rpm Missing dependencies for devel. Unless I'm wrong:
Requires: babl-devel glib2-devel
Since they are checked for explicitly, maybe you could
have an explicit BR on pango and cairo.
Also I suggest using
rm %{buildroot}%{_libdir}/*.la
or, at least
rm -f %{buildroot}%{_libdir}/*.la
(In reply to comment #9) > Missing dependencies for devel. Unless I'm wrong: > Requires: babl-devel glib2-devel > Yes gegl.pc requires both. > Since they are checked for explicitly, maybe you could > have an explicit BR on pango and cairo. > But these are already pulled in by gtk2-devel. Spec URL: ftp://czar.eas.yorku.ca/pub/gegl/gegl.spec SRPM URL: ftp://czar.eas.yorku.ca/pub/gegl/gegl-0.0.13-0.7.20071011svn.fc8.src.rpm * follow guidelines * expected rpmlint warning gegl-devel.i386: W: no-documentation * follow naming guidelines * free software * source match upstream except for dates in .svn/entries * %files section right * library correctly packaged APPROVED New Package CVS Request ======================= Package Name: gegl Short Description: A graph based image processing framework Owners: deji Branches: F-7 F-8 InitialCC: Cvsextras Commits: yes Thanks Patrice for doing the reviews |