Bug 337751

Hmm, won't build for me on F-7:
uic: File generated with too recent version of Qt Designer (4.0 vs. 3.3.8)

When will we get qt4?  F9?

qt4 is in qt4(-devel) and already in F-7, so the BR need to be adjusted.

Thanks, I'll try that.  I suppose searching koji with qt* instead of just qt
would have helped. :)

btw. you need to use qmake-qt4 instead of qmake in the spec.

I did a first build for F7 with all patches disabled and with qmake-qt4 instead
of qmake and it worked. I also removed kdelib from BR, so maybe it is not needed
(anymore). But I spotted a problem, $RPM_OPT_FLAGS is not used to build the
package, which maybe was also a problem for the older release, this should be
changed.

I've got it all ready except for the $RPM_OPT_FLAGS issue.  I've tried it at the
qmake and make steps, and both break.  Any suggestions?

Mock rebuild confirms no need for explicit BR for kdelibs.  Odd.  Took it out.

(In reply to comment #6)
> I've got it all ready except for the $RPM_OPT_FLAGS issue.  I've tried it at the
> qmake and make steps, and both break.  Any suggestions?

What did you do? Here 
qmake-qt4 INSTALLDIR=%{buildroot}%{_prefix} \
QMAKE_CFLAGS="%{optflags}" \
QMAKE_CXXFLAGS="%{optflags}" \
QMAKE_LFLAGS="%{optflags}"
seems to work, but I did not yet test whether it compiles completely. The the
%{optflags} are honoured, though.

I just stuck $RPM_OPT_FLAGS after make and qmake, respectively.

This works great, builds, and tests out OK.  I'll wait a bit to see what the
list brings, then import and build.

Thanks.

Btw.

%find_lang %{name} || touch %{name}.lang
-f %{name}.lang

does not work in your spec, because find_lang does not know about the way vym
handles its translations.

Btw. I cc'ed you in an e-mail with some patches that should make your
maitainance of vym in Fedora a lot easier, especially when they are accepted
upstream. One of them allows you to use

DOCDIR="%{_docdir}/%{name}-%{version}" PREFIX=%{_prefix} after qmake-qt4, which
is essentially, what you did with the {name}-pro.patch patch but not with
hardcoded values. And another also adds DOCDIR to the searchList for the pdf,
like the %{name}-mainwindow.patch patch does in a hardcoded way. And the last
patch makes vym use xdg-open instead of konqueror/acroread to open URLs and
PDFs. Btw. imho the make invocation should be
%{__make} install INSTALL_ROOT=%{buildroot} COPY="%{__cp} -p -f"
because afair DESTDIR is ignored with the makefile, but INSTALL_ROOT is the
variable which does what DESTDIR does for packages that use autotools.

All changes applied and built for rawhide.  Will built for other releases after
F-8 GA.  Thanks!