Bug 343741

Summary:	Review Request: sugar-base - Base Sugar library
Product:	[Fedora] Fedora	Reporter:	Marco Pesenti Gritti <mpg>
Component:	Package Review	Assignee:	Dennis Gilmore <dennis>
Status:	CLOSED NEXTRELEASE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	fedora-package-review, notting, pbrobinson, tomeu
Target Milestone:	---	Flags:	dennis: fedora-review+ kevin: fedora-cvs+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2007-12-07 16:00:49 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Marco Pesenti Gritti 2007-10-20 10:32:30 UTC

Spec URL: http://dev.laptop.org/~marco/sugar-base.spec
SRPM URL: http://dev.laptop.org/~marco/sugar-base-0.1-0.3.20071016git7364e0078e.src.rpm
Description: The base libary for Sugar, the user interface of the One Laptop Per
Child project. It provides helpers for the development of services and
activities.

Comment 1 Jason Tibbitts 2007-10-22 22:18:33 UTC

There is very little chance that anyone will review this if fedora-review is set
to '?' which means 'review in progress'.  It won't show on the review tracker
page.  Could you set it to ' ' unless you have some other reason for it to be
set the way it is?

Comment 2 Marco Pesenti Gritti 2007-10-22 22:22:34 UTC

Ooops got confused by the meaning of ? in other bug systems... Thanks for
letting me now!

Comment 3 Marco Pesenti Gritti 2007-10-30 21:22:26 UTC

I updated spec and srpm to actually build in koji (they are at the same url).

Comment 4 Dennis Gilmore 2007-10-31 18:46:18 UTC

you dont need 

BuildRequires: pkgconfig

any devel package that provides .pc files must Requires it 

some documentation would be nice.

Its the only thing rpmlint complains about.

builds in mock

fix the BuildRequires and i will approve the package.

Comment 5 Marco Pesenti Gritti 2007-11-01 00:34:10 UTC

Removed the unnecessary buildreq:

https://dev.laptop.org/~marco/sugar-base-0.1-0.4.20071016git7364e0078e.src.rpm
https://dev.laptop.org/~marco/sugar-base.spec

(I'll add documentation with the next git snapshot)

Comment 6 Dennis Gilmore 2007-11-01 01:06:31 UTC

looks good now.

Approved.

Comment 7 Marco Pesenti Gritti 2007-11-01 01:27:03 UTC

New Package CVS Request
=======================
Package Name: sugar-base
Short Description: Base Sugar library
Owners: mpg
Branches: OLPC-2
InitialCC: mpg
Cvsextras Commits: no

Comment 8 Dennis Gilmore 2007-11-01 06:14:50 UTC

cvs done

Comment 9 Marco Pesenti Gritti 2008-11-03 17:15:22 UTC

Package Change Request
======================
Package Name: sugar-base
New Branches: F-11

Comment 10 Dennis Gilmore 2008-11-03 18:58:08 UTC

im assuming you mean F-10 

CVS done

Comment 11 Tomeu Vizoso 2008-11-12 11:00:51 UTC

Package Change Request
======================
Package Name: sugar-base
New Branches: OLPC-4
Owners: mpg erikos tomeu

Comment 12 Kevin Fenzi 2008-11-12 16:54:18 UTC

cvs done.

Comment 13 Peter Robinson 2010-06-10 20:49:18 UTC

Package Change Request
======================
Package Name: sugar-base
New Branches: EL-6
Owners: pbrobinson sdz

Comment 14 Kevin Fenzi 2010-06-11 04:32:14 UTC

cvs done.