Bug 344521
| Summary: | Review Request: fprobe-ulog - NetFlow probe | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Paul P Komkoff Jr <i> |
| Component: | Package Review | Assignee: | Parag AN(पराग) <panemade> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | fedora-package-review, kevin, notting |
| Target Milestone: | --- | Flags: | panemade:
fedora-review+
kevin: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | fprobe-ulog-1.1-7.el6 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2007-10-27 14:31:03 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Paul P Komkoff Jr
2007-10-21 15:47:33 UTC
1)Source URL should be http://downloads.sourceforge.net/fprobe/%{name}-%{version}.tar.bz2 2) use defattr as %defattr(-,root,root,-) Done, fprobe-ulog-1.1-3 at the same place. I think it will be good if you provide SPEC as well as SRPM links each time you update package. Otherwise it needs to open download place, browse website and then search for updated SRPM and then download SRPM instead of having direct single click download for updated SRPM. Spec URL: http://palevo.sgu.ru/mockbuild/7/SPECS/fprobe-ulog.spec SRPM URL: http://palevo.sgu.ru/mockbuild/7/SRPMS/fprobe-ulog-1.1-3.fc7.src.rpm Review: + package builds in mock (development i386). + rpmlint is silent for SRPM and for RPM. + source files match upstream url cdb2e4edc47e8a3d5479eeabfb979ebc fprobe-ulog-1.1.tar.bz2 + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc is present. + BuildRequires are proper. + Compiler flags are honoured correctly. + defattr usage is correct. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no headers or static libraries. + no .pc file present. + no -devel subpackage + no .la files. + no translations are available. + Does owns the directories it creates. + no scriptlets present. + no duplicates in %files. + file permissions are appropriate. + Package fprobe-ulog-1.1-3.fc8 -> Requires: libc.so.6 libc.so.6(GLIBC_2.0) libc.so.6(GLIBC_2.1) libc.so.6(GLIBC_2.3.4) libc.so.6(GLIBC_2.4) libpthread.so.0 libpthread.so.0(GLIBC_2.0) libpthread.so.0(GLIBC_2.1) libpthread.so.0(GLIBC_2.3.2) rtld(GNU_HASH) + Not a GUI App. APPROVED. New Package CVS Request ======================= Package Name: fprobe-ulog Short Description: NetFlow probe Owners: stingray Branches: F-7 Cvsextras Commits: yes F-8 branches now exist... so do you really only want F-7 and devel? Or do you want F-8 here as well? Sorry. Of course I want F-8 :) Thx. cvs done. Package Change Request ======================= Package Name: fprobe-ulog New Branches: EL-4 EL-5 cvs done. fprobe-ulog-1.1-7.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/fprobe-ulog-1.1-7.el6 fprobe-ulog-1.1-7.el6 has been pushed to the Fedora EPEL 6 stable repository. |