Bug 34711

Summary: fix RPM creation on IRIX
Product: [Retired] Red Hat Linux Reporter: Joe Orton <jorton>
Component: rpmAssignee: Jeff Johnson <jbj>
Status: CLOSED RAWHIDE QA Contact: David Lawrence <dkl>
Severity: high Docs Contact:
Priority: medium    
Version: 7.0   
Target Milestone: ---   
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2001-04-04 14:13:26 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
First Fwrite fix
none
Second Fwrite fix none

Description Joe Orton 2001-04-04 14:12:00 UTC 
Courtesy of IRIX cc: fix checking of Fwrite() return codes.

"pack.c", line 509: warning(1183): pointless comparison of unsigned integer
          with zero
  	if (Fwrite(buf, sizeof(buf[0]), count, fd) < 0) {

This is particularly nasty since the compiler *optimizes out* the call to
Fwrite(), producing .rpms which aren't really all there.

Patches coming up...
Comment 1 Joe Orton 2001-04-04 14:12:35 UTC 
Created attachment 14623 [details]
First Fwrite fix
Comment 2 Joe Orton 2001-04-04 14:13:22 UTC 
Created attachment 14624 [details]
Second Fwrite fix
Comment 3 Jeff Johnson 2001-04-17 18:29:28 UTC 
Fixed in CVS, will be in rpm-4.0.3-0.5. Thanks for the patch.