Bug 352631

Summary: Underscores in node names are accidentally trimmed in cluster.conf://failoverdomainnode/@name
Product: Red Hat Enterprise Linux 5 Reporter: Satoru SATOH <ssato>
Component: system-config-clusterAssignee: Ryan McCabe <rmccabe>
Status: CLOSED ERRATA QA Contact: Cluster QE <mspqa-list>
Severity: medium Docs Contact:
Priority: medium    
Version: 5.0CC: bbrock, cluster-maint, cward, jzhenyon, sbradley, tao
Target Milestone: ---   
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
: 530200 (view as bug list) Environment:
Last Closed: 2010-03-30 08:54:14 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 530200    
Attachments:
Description Flags
An experimental patch to allow underscores in cluster node names none

Description Satoru SATOH 2007-10-25 16:22:24 UTC
Description of problem: Underscores in node name
(cluster.conf://failoverdomainnode/@name) are accidentally trimmed
because label texts passed to gtk.MenuItem without use_underline parameter.

So if node name includes '_',  //clusternode/@name and 
//failoverdomainnode/@name in cluster.conf becomes mismatched and 
cluster should not work correctly.


Version-Release number of selected component (if applicable):
I confirmed this issue with system-config-cluster in Red Hat Cluster 
Suite 4 U5 and RHEL 5 AP.


How reproducible: always


Steps to Reproduce:
1. set node name includes '_' (underscore)
2. select that node in failover domain dialog

  
Actual results: 
'_' in node name (cluster.conf://failoverdomainnode/@name) is trimmed.


Expected results: Not trimmed.


Additional info:
I attach an experimental patch to fix this issue.

Comment 1 Satoru SATOH 2007-10-25 16:22:24 UTC
Created attachment 237551 [details]
An experimental patch to allow underscores in cluster node names

Comment 2 Satoru SATOH 2007-11-04 00:57:21 UTC
It's a evident problem of the program and easy to fix although host (node) name
should not contain '_', so I raise the level of severity and priority of this.


Comment 5 Chris Ward 2010-02-11 10:13:41 UTC
~~ Attention Customers and Partners - RHEL 5.5 Beta is now available on RHN ~~

RHEL 5.5 Beta has been released! There should be a fix present in this 
release that addresses your request. Please test and report back results 
here, by March 3rd 2010 (2010-03-03) or sooner.

Upon successful verification of this request, post your results and update 
the Verified field in Bugzilla with the appropriate value.

If you encounter any issues while testing, please describe them and set 
this bug into NEED_INFO. If you encounter new defects or have additional 
patch(es) to request for inclusion, please clone this bug per each request
and escalate through your support representative.

Comment 6 Brian Brock 2010-03-09 20:17:03 UTC
fix verified in system-config-cluster-1.0.57-3, cluster.conf looks good for nodes with _ in the name.

Comment 10 errata-xmlrpc 2010-03-30 08:54:14 UTC
An advisory has been issued which should help the problem
described in this bug report. This report is therefore being
closed with a resolution of ERRATA. For more information
on therefore solution and/or where to find the updated files,
please follow the link below. You may reopen this bug report
if the solution does not work for you.

http://rhn.redhat.com/errata/RHBA-2010-0288.html

Comment 11 Ryan McCabe 2010-10-26 20:31:57 UTC
*** Bug 488191 has been marked as a duplicate of this bug. ***