Bug 352741
| Summary: | Review Request: tkimg - More Image Formats for Tk | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Sergio Pascual <sergio.pasra> |
| Component: | Package Review | Assignee: | Marek Mahut <mmahut> |
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | fedora-package-review, notting |
| Target Milestone: | --- | Flags: | mmahut:
fedora-review+
kevin: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2007-10-29 23:07:18 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 352761 | ||
|
Description
Sergio Pascual
2007-10-25 16:51:37 UTC
[-] source files match upstream:
07afc28f7e1149dad65471f387298052 tkimg-1.3.tar.gz
964a692db8a120dc5ed8779521a70bc8 tkimg-1.3.tar.gz.upstream
* I diffed the tree and I see no changes beside owership. Please make sure you
ship the version from sourcefource page.
[+] package meets naming and versioning guidelines.
[+] specfile is properly named and cleanly written.
[-] dist tag is present.
* Please use dist tag for your release tag.
http://fedoraproject.org/wiki/Packaging/DistTag
[+] build root is correct.
%(mktemp -ud %{_tmppath}/%{name}-%{version}-%{release}-XXXXXX)
[+] license field matches the actual license.
[+] license is open source-compatible.
[+] latest version is being packaged.
[+] BuildRequires are proper.
[+] rpmlint is silent.
[+] no duplicates in %files.
[+] file permissions are appropriate.
[+] compiler flags are appropriate.
[+] %clean is present.
[+] package builds in mock (rawhide).
[+] package installs properly.
Please, fix these two errors and provide me with new spec file.
The code is taken directly from the subversion repository. Although the last released tarball is from 2004, the subversion repo has been updated since then. I have added the dist tag to the specfile: Spec URL: http://sergiopr.fedorapeople.org/tkimg.spec SRPM URL: http://sergiopr.fedorapeople.org/tkimg-1.3-0.3.20071018svn.fc7.src.rpm APPROVED. New Package CVS Request ======================= Package Name: tkimg Short Description: More Image Formats for Tk Owners: sergiopr Branches: F-7 F-8 InitialCC: Cvsextras Commits: yes Hi Sergio, when you make a checkout from upstream's revision control system you need to follow these guidelines so that other people can duplicate your checkout: http://fedoraproject.org/wiki/Packaging/SourceURL#RevisionControl You can make those changes once you've imported the source but please do so before you build the package. Thanks! cvs done. I have done as you say, thank you Package Change Request ====================== Package Name: tkimg New Branches: EL-5 cvs done. |