Bug 355581 (koules-review)

Summary:	Review Request: koules - Action game with multiplayer, network and sound support
Product:	[Fedora] Fedora	Reporter:	Lubomir Kundrak <lkundrak>
Component:	Package Review	Assignee:	Marek Mahut <mmahut>
Status:	CLOSED NEXTRELEASE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	fedora-package-review, notting
Target Milestone:	---	Flags:	mmahut: fedora-review+ kevin: fedora-cvs+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2007-11-04 20:15:34 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Lubomir Kundrak 2007-10-28 03:24:38 UTC

Spec URL: http://people.redhat.com/lkundrak/SPECS/koules.spec
SRPM URL:
http://people.redhat.com/lkundrak/mock-results/koules-1.4-1.fc8.i386/koules-1.4-1.fc8.src.rpm
Mock build results:
http://people.redhat.com/lkundrak/mock-results/koules-1.4-1.fc8.i386/
Description: Action game with multiplayer, network and sound support

Koules is a fast action arcade-style game.  It works in fine resolution
with cool 256 color graphics, multiplayer mode up to 5 players, full sound
and, of course, network support.  Koules is an original idea. First version
of Koules was developed from scratch by Jan Hubicka in July 1995.

Remember Red Hat Linux 4.2? Don't tell me you were not playing this!

Comment 1 Marek Mahut 2007-11-04 15:56:42 UTC

[+] package meets naming and versioning guidelines.
[+] specfile is properly named and cleanly written.
[+] dist tag is present.
[+] build root is correct.
      %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
[+] license field matches the actual license.
[+] license is open source-compatible. 
[+] latest version is being packaged.
[+] BuildRequires are proper.
[+] rpmlint is properly silent.
[+] no duplicates in %files.
[+] file permissions are appropriate.
[+] %clean is present.
[+] package builds in mock (rawhide).
[+] package installs properly.

  APPROVED.

Comment 2 Lubomir Kundrak 2007-11-04 16:11:51 UTC

Danke schon, Marek!

New Package CVS Request
=======================
Package Name: koules
Short Description: Action game with multiplayer, network and sound support
Owners: lkundrak
Branches: FC-6 F-7 F-8
Cvsextras Commits: yes

Comment 3 Kevin Fenzi 2007-11-04 19:22:13 UTC

cvs done.

Comment 4 Lubomir Kundrak 2007-11-04 20:15:34 UTC

Thanks, Kevin!

Imported and built.

Comment 5 Lubomir Kundrak 2008-04-11 18:30:11 UTC

Package change Request
=======================
Package Name: koules
New Branches: EL-5
Cvsextras Commits: yes

Comment 6 Kevin Fenzi 2008-04-12 21:48:50 UTC

cvs done.