Bug 359921

Drupal 6.0 is hitting rawhide, the 6.x version is not ready and depends upon the
6.x version of views.

Spec URL: http://zanoni.jcomserv.net/fedora/drupal-cck/drupal-cck.spec
SRPM URL:
http://zanoni.jcomserv.net/fedora/drupal-cck/drupal-cck-6.x.2.0-0.beta.fc9.src.rpm

Updated for Drupal 6.x, ready to review.

Could you update this again to the current stable? According to the changelog
there have been some major changes and important fixes since 2.0-beta.

Done:
http://zanoni.jcomserv.net/fedora/drupal-cck/drupal-cck.spec
http://zanoni.jcomserv.net/fedora/drupal-cck/drupal-cck-6.x.2.0-0.rc4.fc9.src.rpm

UPGRADE.txt, DEVELOPER.txt and CHANGELOG.txt should be %doc

%doc-Files shouldn't be duplicated to %{drupaldir}

Corrected:
http://zanoni.jcomserv.net/fedora/drupal-cck/drupal-cck.spec
http://zanoni.jcomserv.net/fedora/drupal-cck/drupal-cck-6.x.2.0-1.rc4.fc9.src.rpm

The %doc-Files still appear twice:

[root@f9test ~]# rpm -ql drupal-cck | grep CHANGELOG
/usr/share/doc/drupal-cck-6.x.2.0/CHANGELOG.txt
/usr/share/drupal/modules/cck/CHANGELOG.txt

REALLY Corrected:
http://zanoni.jcomserv.net/fedora/drupal-cck/drupal-cck.spec
http://zanoni.jcomserv.net/fedora/drupal-cck/drupal-cck-6.x.2.0-2.rc4.fc9.src.rpm

Package Review
==============

Key:
 - = N/A
 x = Check
 ! = Problem
 ? = Not evaluated

=== REQUIRED ITEMS ===
 [x] Package is named according to the Package Naming Guidelines.
 [x] Spec file name must match the base package %{name}, in the format %{name}.spec.
 [x] Package meets the Packaging Guidelines.
 [x] Package successfully compiles and builds into binary rpms on at least one
supported architecture.
     Tested on: f9/i386
 [x] Rpmlint output:
source RPM: empty
binary RPM:empty
 [x] Package is not relocatable.
 [x] Buildroot is correct
(%{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n))
 [x] Package is licensed with an open-source compatible license and meets other
legal requirements as defined in the legal section of Packaging Guidelines.
 [x] License field in the package spec file matches the actual license.
     License type:GPLv2
[x] If (and only if) the source package includes the text of the license(s) in
its own file, then that file, containing the text of the license(s) for the
package is included in %doc.
 [x] Spec file is legible and written in American English.
 [x] Sources used to build the package matches the upstream source, as provided
in the spec URL.
     SHA1SUM of package: 94e6b2822aaf1421243e1908c7facb5e94ba59cc
cck-6.x-2.0-rc4.tar.gz
 [x] Package is not known to require ExcludeArch
 [x] All build dependencies are listed in BuildRequires, except for any that are
listed in the exceptions section of Packaging Guidelines.
 [-] The spec file handles locales properly.
 [-] ldconfig called in %post and %postun if required.
 [x] Package must own all directories that it creates.
 [x] Package requires other packages for directories it uses.
 [x] Package does not contain duplicates in %files.
 [x] Permissions on files are set properly.
 [x] Package has a %clean section, which contains rm -rf %{buildroot} (or
$RPM_BUILD_ROOT).
 [x] Package consistently uses macros.
 [x] Package contains code, or permissable content.
 [-] Large documentation files are in a -doc subpackage, if required.
 [x] Package uses nothing in %doc for runtime.
 [-] Header files in -devel subpackage, if present.
 [-] Static libraries in -devel subpackage, if present.
 [-] Package requires pkgconfig, if .pc files are present.
 [-] Development .so files in -devel subpackage, if present.
 [-] Fully versioned dependency in subpackages, if present.
 [x] Package does not contain any libtool archives (.la).
 [-] Package contains a properly installed %{name}.desktop file if it is a GUI
application.
 [x] Package does not own files or directories owned by other packages.

=== SUGGESTED ITEMS ===
 [x] Latest version is packaged.
 [x] Package does not include license text files separate from upstream.
 [-] Description and summary sections in the package spec file contains
translations for supported Non-English languages, if available.
 [x] Reviewer should test that the package builds in mock.
     Tested on: f9/i386
 [?] Package should compile and build into binary rpms on all supported
architectures.
     Tested on:
 [x] Package functions as described.
 [-] Scriptlets must be sane, if used.
 [-] The placement of pkgconfig(.pc) files is correct.
 [-] File based requires are sane.

APPROVED

Thanks!

New Package CVS Request
=======================
Package Name: drupal-cck
Short Description: Allows you to create and customize fields using a web browser
Owners: limb
Branches: F-9
InitialCC:
Cvsextras Commits: yes

cvs done.

drupal-cck-6.x.2.0-2.rc4.fc9 has been submitted as an update for Fedora 9

drupal-cck-6.x.2.0-2.rc4.fc9 has been pushed to the Fedora 9 testing repository.  If problems still persist, please make note of it in this bug report.
 If you want to test the update, you can install it with 
 su -c 'yum --enablerepo=updates-testing update drupal-cck'.  You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F9/FEDORA-2008-6966

drupal-cck-6.x.2.0-2.rc4.fc9 has been pushed to the Fedora 9 stable repository.  If problems still persist, please make note of it in this bug report.

Closing.

Package Change Request
======================
Package Name: drupal-cck
New Branches: el5 el6
Owners: limb

Git done (by process-git-requests).