Bug 361201

OK - rpmlint
OK - Package name
OK - License info is accurate
OK - License tag is correct and licenses are approved
OK - Specfile name
OK - Specfile is legible
OK - No prebuilt binaries included
OK - PreReq not used
OK - Source md5sum matches upstream
OK - No hardcoded pathnames
OK - Package owns all the files it installs
OK - Package requires create needed unowned directories
OK - Package builds successfully on i386 and x86_64 
OK - BuildRequires sufficient
OK - File permissions set properly (except for rpmlint error below)
OK - Macro usage is consistent

OK - Package is named rubygem-%{gemname}
OK - Source points to full URL of gem
OK - Package version identical with gem version
OK - Package Requires and BuildRequires rubygems
OK - Package provides rubygem(%{gemname}) = %version
OK - Package requires gem dependencies correctly
OK - %prep and %build are empty
OK - %gemdir defined properly, and gem installed into it
OK - Package owns its directories under %gemdir
OK - No arch-specific content in %{gemdir}
OK - Package is noarch

??? - BuildRoot value: not sure if this is really a problem, but it
  looks like %{release} is omitted:

  BuildRoot: %{_tmppath}/%{name}-%{version}-root-%(%{__id_u} -n)
 vs.
             %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)

FIX - README, CHANGELOG not installed as %doc
  general doc question: docs are included as regular gem
  files in %{geminstdir}, but not in %{_docdir}/%{name}-%{version} as
  in some of the packages Is there a clear preference for doc location?

I fixed the buildroot, and added the README and CHANGELOG to _docdir

I don't think there's a hard-and-fast rule for which docs need to go into
_docdir vs geminstdir, as long as they are properly marked with %doc. I have
tried to put things into _docdir that you would usually look for there, mostly
very simple things like license texts and readmes.

Spec URL: http://people.redhat.com/dlutter/yum/spec/rubygem-activesupport.spec
SRPM URL:
http://people.redhat.com/dlutter/yum/SRPMS/rubygem-activesupport-1.4.4-2.src.rpm

I think you forgot the buildroot change on this one. otherwise everything's fine.

New Package CVS Request
=======================
Package Name: rubygem-activesupport
Short Description: Support and utility classes used by the Rails framework
Owners: lutter,sseago
Branches: F-7 F-8
InitialCC: 
Cvsextras Commits: yes

Ignore the last comment .. added the CVS request prematurely.

Fixed the buildroot.

Spec URL: http://people.redhat.com/dlutter/yum/spec/rubygem-activesupport.spec
SRPM URL:
http://people.redhat.com/dlutter/yum/SRPMS/rubygem-activesupport-1.4.4-3.src.rpm

approved

New Package CVS Request
=======================
Package Name: rubygem-activesupport
Short Description: Support and utility classes used by the Rails framework
Owners: lutter,sseago
Branches: F-7 F-8
InitialCC: 
Cvsextras Commits: yes

cvs done.

Successfully imported and built.

Hi David,

Could you update this gem to the newest version ?