Bug 361241

Summary: Review Request: rubygem-actionwebservice - Web service support for Action Pack
Product: [Fedora] Fedora Reporter: David Lutterkort <lutter>
Component: Package ReviewAssignee: Scott Seago <sseago>
Status: CLOSED RAWHIDE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: fedora-package-review, hbrock, notting
Target Milestone: ---Flags: sseago: fedora-review+
kevin: fedora-cvs+
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2007-12-03 23:50:19 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 361191    

Description David Lutterkort 2007-11-01 01:55:08 UTC
Spec URL: http://people.redhat.com/dlutter/yum/spec/rubygem-actionwebservice.spec
SRPM URL: http://people.redhat.com/dlutter/yum/SRPMS/rubygem-actionwebservice-1.2.5-1.src.rpm

Description:

Adds WSDL/SOAP and XML-RPC web service support to Action Pack

Comment 1 Scott Seago 2007-11-07 16:53:55 UTC
OK - Package name
OK - License info is accurate
OK - License tag is correct and licenses are approved
OK - Specfile name
OK - Specfile is legible
OK - No prebuilt binaries included
OK - PreReq not used
OK - Source md5sum matches upstream
OK - No hardcoded pathnames
OK - Package owns all the files it installs
OK - Package requires create needed unowned directories
OK - Package builds successfully on i386 and x86_64 
OK - BuildRequires sufficient
OK - File permissions set properly (except for rpmlint error below)
OK - Macro usage is consistent

OK - Package is named rubygem-%{gemname}
OK - Source points to full URL of gem
OK - Package version identical with gem version
OK - Package Requires and BuildRequires rubygems
OK - Package provides rubygem(%{gemname}) = %version
OK - Package requires gem dependencies correctly
OK - %prep and %build are empty
OK - %gemdir defined properly, and gem installed into it
OK - Package owns its directories under %gemdir
OK - No arch-specific content in %{gemdir}
OK - Package is noarch

??? - BuildRoot value: not sure if this is really a problem, but it
  looks like %{release} is omitted:

  BuildRoot: %{_tmppath}/%{name}-%{version}-root-%(%{__id_u} -n)
 vs.
             %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)

FIX - TODO not installed as %doc
  general doc question: docs are installed as doc in
  %{_docdir}/%{name}-%{version} but still included as regular gem
  files in %{geminstdir} -- should they be in one place or the other
  but not both? Is there a clear preference (some of the other rubygem
  packages -- both yours and mine include the doc in the gem, not in /usr/share/doc

FIX - rpmlint complains 
E: rubygem-actionwebservice non-executable-script
/usr/lib/ruby/gems/1.8/gems/actionwebservice-1.2.5/test/gencov 0644
E: rubygem-actionwebservice non-executable-script
/usr/lib/ruby/gems/1.8/gems/actionwebservice-1.2.5/test/run 0644


Comment 2 David Lutterkort 2007-11-14 04:32:52 UTC
Fixed: buildroot
Fixed: marked things in geminstdir properly as %doc

The two rpmlint complaints are about test helper scripts - I don't want to force
them to mode 644 for security, but also want to change as little as has to be
changed from upstream (like editing out the #! lines). So I've left them as is.

Spec URL: http://people.redhat.com/dlutter/yum/spec/rubygem-actionwebservice.spec
SRPM URL:
http://people.redhat.com/dlutter/yum/SRPMS/rubygem-actionwebservice-1.2.5-2.src.rpm

Comment 3 Scott Seago 2007-11-14 21:59:50 UTC
Approved

Comment 4 David Lutterkort 2007-11-28 19:21:04 UTC
New Package CVS Request
=======================
Package Name: rubygem-actionwebservice
Short Description: Web service support for Action Pack
Owners: lutter,sseago
Branches: F-7 F-8
InitialCC: 
Cvsextras Commits: yes

Comment 5 Kevin Fenzi 2007-11-28 23:25:11 UTC
cvs done.

Comment 6 David Lutterkort 2007-12-03 23:50:19 UTC
Successfully imported and built.