Bug 363901
Summary: | GFS2: sysfs "id" file should contain device id | ||||||
---|---|---|---|---|---|---|---|
Product: | Red Hat Enterprise Linux 5 | Reporter: | Robert Peterson <rpeterso> | ||||
Component: | kernel | Assignee: | Don Zickus <dzickus> | ||||
Status: | CLOSED ERRATA | QA Contact: | GFS Bugs <gfs-bugs> | ||||
Severity: | high | Docs Contact: | |||||
Priority: | high | ||||||
Version: | 5.1 | CC: | lwang, swhiteho | ||||
Target Milestone: | --- | ||||||
Target Release: | --- | ||||||
Hardware: | All | ||||||
OS: | Linux | ||||||
Whiteboard: | |||||||
Fixed In Version: | RHBA-2008-0314 | Doc Type: | Bug Fix | ||||
Doc Text: | Story Points: | --- | |||||
Clone Of: | Environment: | ||||||
Last Closed: | 2008-05-21 15:00:32 UTC | Type: | --- | ||||
Regression: | --- | Mount Type: | --- | ||||
Documentation: | --- | CRM: | |||||
Verified Versions: | Category: | --- | |||||
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
Cloudforms Team: | --- | Target Upstream Version: | |||||
Embargoed: | |||||||
Bug Depends On: | |||||||
Bug Blocks: | 354201 | ||||||
Attachments: |
|
Description
Robert Peterson
2007-11-02 14:44:17 UTC
Requesting ack flags to get this in the 5.2 kernel. This request was evaluated by Red Hat Product Management for inclusion in a Red Hat Enterprise Linux maintenance release. Product Management has requested further review of this request by Red Hat Engineering, for potential inclusion in a Red Hat Enterprise Linux Update release for currently deployed products. This request is not yet committed for inclusion in an Update release. Dave Teigland had a good point about being careful when changing the abi. Following his lead, I found out that if we switch the value of the "id" file as suggested in the patch, older versions of the gfs2_tool that expect it the other way will break. In other words, the users would then be required to upgrade their gfs2_tool. That might be acceptable for RHEL because we can control it, but it probably won't fly for upstream. Therefore, I propose we instead export the device id to a new sysfs file called device_id. That way we won't break anything. My big question is: Are there any kabi requirements here that I don't know about? Is it okay to create a new sysfs file for gfs2? How will that be viewed by the upstream community? We discussed the patch in Monday's gfs2 tech meeting, and we decided that there shouldn't be an issue exporting the device "major:minor" in the ID file. Other file systems do this, so it should be okay for us. Right now, gfs2 is still in tech preview and no one in RHEL or the upstream community should be under the impression that it's ready for enterprise use yet, so making this change to the kernel abi seemed acceptable to everyone in the meeting. Therefore, we decided to go ahead with the patch as is and not try to create a new device_id file. I've tested with that already. I'll attach the patch to this bz and post it to rhkernel-list for inclusion in RHEL5.2. The kernel should really have a better solution for this that works for all file systems. Perhaps we should create some kind of interface that works for all file systems and propose it on lkml. Time permitting. Created attachment 249291 [details]
Patch to fix the problem
Here is the patch I'm going to post to rhkernel-list.
Posted to rhkernel-list. Turning it over to Don Zickus. in 2.6.18-58.el5 You can download this test kernel from http://people.redhat.com/dzickus/el5 An advisory has been issued which should help the problem described in this bug report. This report is therefore being closed with a resolution of ERRATA. For more information on the solution and/or where to find the updated files, please follow the link below. You may reopen this bug report if the solution does not work for you. http://rhn.redhat.com/errata/RHBA-2008-0314.html |