Bug 367341

Some random comments for 0.4.2-1:

* rpmlint
  - Please check your srpm/binary rpms by rpmlint before submitting
    to Review request.
------------------------------------------------------------
E: description-line-too-long Rubyripper is a digital audio extraction algorithm
that uses cdparanoia in a sophisticated
E: description-line-too-long way to make sure that a CD rip is done successfully
and accurately. It is very similar to
W: non-standard-group Application/Multimedia
W: invalid-license GPL
------------------------------------------------------------
   You can see what these rpmlint complaint means by
   "rpmlint -I description-line-too-long", for example.

   - For license, please refer to 
     http://fedoraproject.org/wiki/Packaging/LicensingGuidelines
     http://fedoraproject.org/wiki/Licensing

* Ruby packaging issue:
  For general ruby packaging issues, please refer to:
  http://fedoraproject.org/wiki/Packaging/Ruby .

  - Ruby lib dependy
    - This package should have "Requires: ruby(abi) = 1.8'.

  - Ruby module dependency
    - For ruby module dependency, please specify them by module names,
      not by rpm names like perl. For example: "Requires: ruby(gtk2)"

  - Ruby dependency
    Note: ruby-gtk2 itself requires ruby-libs, but does not require ruby.

* koji build
  - koji build failed. At least desktop-file-utils is missing for BR.
    http://koji.fedoraproject.org/koji/taskinfo?taskID=227431

- Add missing BRs
- Use modules, not package names in ruby Requires
- Update License tag
- Fix description
- Add ruby BR to make sure getting ruby_sitelib works

Spec URL: http://sindrepb.fedorapeople.org/packages/rubyripper.spec
SRPM URL: http://sindrepb.fedorapeople.org/packages/rubyripper-0.4.2-2.fc8.src.rpm

For 0.4.2-2:

* License
  - The license of this package is actually GPLv3+.

* ruby dependency
  - Well, what I meant is that ruby(abi), ruby(gtk2) both
    require ruby-libs, but do not require ruby.
    So Requires also should have: "Requires: ruby".

! ruby(abi) BuildRequires dependency
  - For consistency with "Requires: ruby(abi) = 1.8", I
    recommend to also add "BuildRequires: ruby(abi) = 1.8".

Updated:

- Add Requires: ruby
- Fix License tag
- Update ruby BR for consistency

Spec URL: http://sindrepb.fedorapeople.org/packages/rubyripper.spec
SRPM URL: http://sindrepb.fedorapeople.org/packages/rubyripper-0.4.2-3.fc8.src.rpm

Okay.

-------------------------------------------------------------
   This package (rubyripper) is APPROVED by me
-------------------------------------------------------------

0.4.3 was just released, with some changes upstream that caused me to make some
changes to my spec. Just to make sure the package is still kosher, could you
have another look?

Changes:
- New release
- Add ruby-gettext, rubygem-rake and gettext dependencies
- Split package into core and gui
- Add translations shebang

Spec URL: http://sindrepb.fedorapeople.org/packages/rubyripper.spec
SRPM URL: http://sindrepb.fedorapeople.org/packages/rubyripper-0.4.3-1.fc8.src.rpm

Well, for 0.4.3-1:

* EVR specific dependency between subpackages
  - Usually the dependency between subpackages must be
    EVR specific, i.e. 
    "Requires: %{name} = %{version}-%{release}".

! Duplicate documents
  - Not a blocker, however I don't think "%doc GPL-3.txt README"
    is also needed for -gui package.

* Ruby module dependency
  - rubyripper (binary) rpm requires ruby(gettext-package)
    (not only BuildRequires).
    /usr/lib/ruby/site_ruby/1.8/rr_lib.rb :
---------------------------------------------------------
    21  begin
    22    require 'gettext'
    23  rescue LoadError
    24    puts "RubyGems is not found. Please install ruby-gettext."
    25  end
---------------------------------------------------------
    (Note: rubygem is not needed)

* Permission
  - Also, please check the permissions of installed files.
    Apparently, gettext .mo files and png file have wrong permissions.

Updated:

- Add missing ruby-gettext Requires
- Fix EVR specific subpackage Requires
- Fix permissions

Spec URL: http://sindrepb.fedorapeople.org/packages/rubyripper.spec
SRPM URL: http://sindrepb.fedorapeople.org/packages/rubyripper-0.4.3-2.fc8.src.rpm

Okay, please go ahead.

New Package CVS Request
=======================
Package Name: rubyripper
Short Description: Open-source secure ripper for Linux
Owners: sindrepb
Branches: F-8 F-7
InitialCC: 
Cvsextras Commits: yes

cvs done.