Bug 367871

Summary:	Review Request: gnome-theme-curvylooks - A modern Clearlooks theme using a Bluecurve-like color scheme
Product:	[Fedora] Fedora	Reporter:	Peter Gordon <peter>
Component:	Package Review	Assignee:	Stewart Adam <s.adam>
Status:	CLOSED ERRATA	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	fedora-package-review, notting
Target Milestone:	---	Flags:	s.adam: fedora-review+ kevin: fedora-cvs+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:	0.2-1.fc8	Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2007-12-03 11:40:28 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Peter Gordon 2007-11-06 03:29:16 UTC

Spec URL: http://pgordon.fedorapeople.org/for-review/gnome-theme-curvylooks.spec
SRPM URL: http://pgordon.fedorapeople.org/for-review/gnome-theme-curvylooks-0.2-1.src.rpm

Description:
CurvyLooks, inspired by and based heavily on the work of Billy Cantrell's
Clearlooks_Cairo-Curve theme, is a simple theme for GTK+ which uses modern
features of the Clearlooks engine and a Bluecurve-like color scheme to provide
a rich and aesthetically-pleasing desktop experience, especially after
prolonged periods of usage.


rpmlint is silent on both the source and binary (noarch) RPMs.

Comment 1 Stewart Adam 2007-11-17 17:25:05 UTC

+ source files match upstream: c68acb3013b82b0e3852f3a5da46aa869be00832

+ package meets naming and versioning guidelines.
+ specfile is properly named, is cleanly written and uses macros consistently.
+ dist tag is present.
+ build root is correct.
+ license field matches the actual license.
+ license is open source-compatible.
+ latest version is being packaged.
+ BuildRequires are proper.
+ %clean is present.
+ package builds in mock ( ).
+ package installs properly
+ rpmlint is silent.
+ final provides and requires are sane:
  * Provides:
    gnome-theme-curvylooks = 0.2-1.fc8
  * Requires:
    gtk2-engines >= 2.12
    rpmlib(CompressedFileNames) <= 3.0.4-1
    rpmlib(PayloadFilesHavePrefix) <= 4.0-1
+ no shared libraries are added to the regular linker search paths.
+ owns the directories it creates.
+ doesn't own any directories it shouldn't.
+ no duplicates in %files.
+ file permissions are appropriate.
+ no scriptlets present.
+ %docs are not necessary for the proper functioning of the package.
+ no headers.
+ no pkgconfig files.
+ no libtool .la droppings.
+ not a GUI app.
ACCEPTED

Comment 2 Peter Gordon 2007-11-17 18:46:01 UTC

Yay! Thanks for the review, Stewart.

New Package CVS Request
=======================
Package Name: gnome-theme-curvylooks
Short Description: A modern Clearlooks theme using a Bluecurve-like color scheme
Owners: pgordon
Branches: F-8 devel
InitialCC: (none)
Cvsextras Commits: yes

Comment 3 Kevin Fenzi 2007-11-18 01:11:34 UTC

cvs done.

Comment 4 Peter Gordon 2007-11-18 05:28:55 UTC

Imported and built for devel/F-8. Thanks.

Comment 5 Fedora Update System 2007-11-20 17:53:02 UTC

gnome-theme-curvylooks-0.2-1.fc8 has been pushed to the Fedora 8 testing repository.  If problems still persist, please make note of it in this bug report.
 If you want to test the update, you can install it with 
 su -c 'yum --enablerepo=updates-testing update gnome-theme-curvylooks'

Comment 6 Fedora Update System 2007-12-03 11:40:27 UTC

gnome-theme-curvylooks-0.2-1.fc8 has been pushed to the Fedora 8 stable repository.  If problems still persist, please make note of it in this bug report.