Bug 368161
| Summary: | Review Request: awn-extras-applets - extras applets of avant window navigator | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Peng Huang <phuang> |
| Component: | Package Review | Assignee: | Stewart Adam <s.adam> |
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | fedora-package-review, jdeslip, notting |
| Target Milestone: | --- | Flags: | s.adam:
fedora-review+
kevin: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2007-11-17 18:25:24 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Peng Huang
2007-11-06 12:18:25 UTC
+ source files match upstream: d19dd1693a1a99613393006f846246c8328f68c9 + package meets naming and versioning guidelines. + specfile is properly named, is cleanly written and uses macros consistently. + dist tag is present. + build root is correct. - license field matches the actual license. ** License is GPLv2 or any later version - Please change the license tag to GPLv2+ + license is open source-compatible, license text included in package. + latest version is being packaged. + BuildRequires are proper. + compiler flags are appropriate. + %clean is present. - package builds in mock ** avant-window-navigator-python is not included in the Fedora repositories nor is it under review. - package installs properly Apart from note above, it works very well + debuginfo package looks complete. + rpmlint is silent. + final provides and requires are sane + no shared libraries are added to the regular linker search paths. + owns the directories it creates. + doesn't own any directories it shouldn't. + no duplicates in %files. + file permissions are appropriate. + code, not content. + %docs are not necessary for the proper functioning of the package. + no headers. + no pkgconfig files. + no libtool .la droppings. Scratch out the part about avant-window-navigator-python, it is currently in updates-testing for F8. All that remains to do is to update the license tag. I changed license tag and updated the spec and srpm files. Please recheck it. Thanks ACCEPTED New Package CVS Request ======================= Package Name: awn-extras-applets Short Description: Extras applets of avant window navigator Owners: phuang Branches: F-8 InitialCC: Cvsextras Commits: yes cvs done. I was about to add the same request for this package. I see it is in development repo now, will it be coming to F8? yeah. I have built it for F8 and requested for F8 repo. The request is pending now. Now that it has been built, we can close this. |