Bug 369211
| Summary: | Review Request: monit - Manages and monitors processes, files, directories and devices | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Stewart Adam <s.adam> |
| Component: | Package Review | Assignee: | Parag AN(पराग) <panemade> |
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | fedora-package-review, gauret, notting |
| Target Milestone: | --- | Flags: | panemade:
fedora-review+
kevin: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2007-11-15 04:07:26 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Stewart Adam
2007-11-06 22:54:16 UTC
mock build went fine. rpmlint warnings looks ok in this case then. monit.i386: E: non-readable /etc/monit.conf 0600 The file can't be read by everybody. If this is expected (for security reasons), contact your rpmlint distributor to get it added to the list of exceptions for your distro (or add it to your local configuration if you installed rpmlint from the source tarball). monit.i386: W: incoherent-subsys /etc/rc.d/init.d/monit $prog The filename of your lock file in /var/lock/subsys/ is incoherent with your actual init script name. For example, if your script name is httpd, you have to use 'httpd' as the filename in your subsys directory. It is also possible that rpmlint gets this wrong, especially if the init script contains nontrivial shell variables and/or assignments. These cases usually manifest themselves when rpmlint reports that the subsys name starts a with '$'; in these cases a warning instead of an error is reported and you should check the script manually. I saw included LICENSE file said this is GPLv3 licensed package. Upstream is using openssl as ssl support. I think currently ssl support should be enabled using nss. https://bugzilla.redhat.com/show_bug.cgi?id=333741 Preserve timestamp http://fedoraproject.org/wiki/Packaging/Guidelines#head-0239576e441f9ef53d175c4aec8c12868dffb5ab I don't have much experience with C or Makefiles... I managed to get Monit recognize the --with-nss_compat option for switching for NSS, but make fails (I think) because as NSS does not implement all the functions OpenSSL does. Can we leave it as OpenSSL for now? New Spec and SRPM for license and timestamp: Spec URL: http://www.diffingo.com/downloads/diffingo-repo/review/monit.spec SRPM URL: http://www.diffingo.com/downloads/diffingo-repo/review/monit-4.10.1-2.fc8.src.rpm sure we can leave nss issue. mock build failed. I got checking for SSL include directory... Not found Couldn't find your SSL header files. I think you changed BR from openssl-devel to nss-devel. New Spec and SRPM for fixed BR: Spec URL: http://www.diffingo.com/downloads/diffingo-repo/review/monit.spec SRPM URL: http://www.diffingo.com/downloads/diffingo-repo/review/monit-4.10.1-2.fc8.1.src.rpm Good to keep disttag simple as fc8 only and not fc8.1 Review: + package builds in mock (development i386). + rpmlint is silent for SRPM But NOT for RPM. monit.i386: E: non-readable /etc/monit.conf 0600 monit.i386: W: incoherent-subsys /etc/rc.d/init.d/monit $prog monit.i386: W: incoherent-subsys /etc/rc.d/init.d/monit $prog monit.i386: W: incoherent-subsys /etc/rc.d/init.d/monit $prog ==> looks ok to accept with these messages for this package. + source files match upstream url d3143b0bbd79b53f1b019d2fc1dae656 monit-4.10.1.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc is present. + BuildRequires are proper. + Compiler flags are honoured correctly. + defattr usage is correct. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no headers or static libraries. + no .pc file present. + no -devel subpackage + no .la files. + no translations are available. + Does owns the directories it creates. + services scriptlets present. + no duplicates in %files. + file permissions are appropriate. + Package monit-4.10.1-2.fc8.1 -> Provides: config(monit) = 4.10.1-2.fc8.1 Requires: /bin/bash config(monit) = 4.10.1-2.fc8.1 libc.so.6 libc.so.6(GLIBC_2.0) libc.so.6(GLIBC_2.1) libc.so.6(GLIBC_2.1.3) libc.so.6(GLIBC_2.2) libc.so.6(GLIBC_2.3) libc.so.6(GLIBC_2.3.4) libc.so.6(GLIBC_2.4) libcrypt.so.1 libcrypt.so.1(GLIBC_2.0) libcrypto.so.6 libnsl.so.1 libpthread.so.0 libpthread.so.0(GLIBC_2.0) libpthread.so.0(GLIBC_2.1) libpthread.so.0(GLIBC_2.2) libresolv.so.2 libssl.so.6 rtld(GNU_HASH) + Not a GUI App. APPROVED. New Package CVS Request ======================= Package Name: monit Short Description: Manages and monitors processes, files, directories and devices Owners: firewing Branches: F-7 F-8 InitialCC: firewing Cvsextras Commits: yes cvs done. monit-4.10.1-3.fc8 has been pushed to the Fedora 8 stable repository. If problems still persist, please make note of it in this bug report. Package Change Request ====================== Package Name: monit New Branches: EL-4 EL-5 cvs done. |