Bug 374871

Summary: Wireless led no longer working on Inspiron 1501 with b43 driver
Product: [Fedora] Fedora Reporter: Dario Castellarin <req1348>
Component: kernelAssignee: John W. Linville <linville>
Status: CLOSED CURRENTRELEASE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: low Docs Contact:
Priority: low    
Version: 8CC: cebbert, davej, jean-luc.richier, mellomann01, uwe
Target Milestone: ---   
Target Release: ---   
Hardware: x86_64   
OS: Linux   
Whiteboard:
Fixed In Version: 2.6.23.12-99.fc8 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2007-12-20 13:49:44 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Dario Castellarin 2007-11-10 17:45:41 UTC
Description of problem:
With the upgrade to kernel 2.6.23.1-49.fc8, the wireless led of my Dell Inspiron
1501 stopped working, while it used to work with all previous kernel versions.
Wireless networking works without problems though...


Version-Release number of selected component (if applicable):
[dario@localhost ~]$ uname -a
Linux localhost.localdomain 2.6.23.1-49.fc8 #1 SMP Thu Nov 8 22:14:09 EST 2007
x86_64 x86_64 x86_64 GNU/Linux


How reproducible:
Always

Steps to Reproduce:
1. Copy proper firmware files in /lib/firmware/b43
2. modprobe b43
3.
  
Actual results:
Wireless works, but the wireless led doesn't turn on. Fn+F2 doesn't toggle it
either.

Expected results:
Wireless led turns on during startup, Fn+F2 toggles it.

Additional info:
[dario@localhost ~]$ dmesg | grep b43
b43-phy0: Broadcom 4311 WLAN found
b43-phy0 debug: Found PHY: Analog 4, Type 2, Revision 8
b43-phy0 debug: Found Radio: Manuf 0x17F, Version 0x2050, Revision 2
b43-phy0 debug: Loading firmware version 351.126 (2006-07-29 05:54:02)
Registered led device: b43-phy0:tx
Registered led device: b43-phy0:rx
b43-phy0 debug: Chip initialized
b43-phy0 debug: 32-bit DMA initialized
b43-phy0 debug: Wireless interface started
b43-phy0 debug: Adding Interface type 2
b43-phy0 debug: Using hardware based encryption for keyidx: 0, mac:
00:11:50:e8:c6:a0


Previous kernels didn't register any led devices, but it used to work without
problems. I think this is a new feature that was recently introduced upstream,
that made my wireless led non-functional.

Comment 1 Dave Maley 2007-11-15 04:35:10 UTC
I'm seeing the same thing here on my HP dv2120, also a 4311 chipset.  Glad to
provide further details if needed, otherwise will gladly test potential fixes ....

Comment 2 Dario Castellarin 2007-11-20 16:57:07 UTC
Same behavior with kernel 2.6.23.1-58.fc8 from Koji build.

Comment 3 Jackie 2007-11-24 17:13:59 UTC
I have the same problem on a Dell Inspiron B130 with kernel 2.6.23.1-49.fc8 and
a broadcom 4318 wireless.

Comment 4 Jean-Luc Richier 2007-11-26 09:39:05 UTC
I have the same problem with a Dell Latitude D620 (b43 driver, 1390/4311 chip)
Also, the radio kill hard switch is not detected anymore.

I have looked in the source, and the problem seems to be in the new rfkill code:
It uses an input polled device and the rfkill module. However the poll function
(in b43/rfkill;c) which tests the radio kill hard switch is never called.
I tried to trace, and it seems that the input polled device open routine (which
starts the poll periodic function) is not called.
I shall investigate further.




Comment 5 Jean-Luc Richier 2007-11-26 10:08:36 UTC
The following method allows the led and the radio kill hard switch to work:

- Load the rfkill-input module (modprobe rfkill-input) BEFORE the load of the
b43 module.
Then, when the input polled device in b43 is registered, it is connected to the
input_handler in rfkill-input and thus opened, staring the periodic poll.

However in kernel 2.6.23.1-49.fc8 the b43 module depends on the rfkill module
but not on the rfkill-input module.
May be some dependancy is missing.


Comment 6 Dario Castellarin 2007-12-20 10:03:04 UTC
I tested today kernel 2.6.23.12-99.fc8 from Koji and the wireless led is back
working!
I noticed that it adds a handler for wireless radio led

Registered led device: b43-phy0:radio

I guess that was the culprit... Good job!

This bug can be closed for what regards me...