Bug 378431

1) remove .la files from installing.
2) remove unnecessary BR's
pkgconfig,gdk-pixbuf-devel,pygobject2-devel,gtk+-devel.pkgconfig
3) Source URL should be
http://files.conduit-project.org/releases/%{name}-%{version}.tar.gz
4) good to add test files from test directory as %doc

rpmlint complained
evolution-python.i386: W: devel-file-in-non-devel-package
/usr/lib/pkgconfig/evolution-python.pc
A development file (usually source code) is located in a non-devel
package. If you want to include source code in your package, be sure to
create a development package.

(In reply to comment #1)
> 1) remove .la files from installing.
Ooops.  I did my removal on the wrong directory :)  Fixed.

> 2) remove unnecessary BR's
> pkgconfig,gdk-pixbuf-devel,pygobject2-devel,gtk+-devel.pkgconfig
Fixed.

> 3) Source URL should be
> http://files.conduit-project.org/releases/%{name}-%{version}.tar.gz
Fixed.

> 4) good to add test files from test directory as %doc
Fixed.

(In reply to comment #2)
> rpmlint complained
> evolution-python.i386: W: devel-file-in-non-devel-package
> /usr/lib/pkgconfig/evolution-python.pc
> A development file (usually source code) is located in a non-devel
> package. If you want to include source code in your package, be sure to
> create a development package.

If I put the .pc file in a -devel package it will be the only file in the
package.  This seems silly.  There has been discussion in the past on the
packaging list whether this rule should be bent or not for this particular case.
 I'm in the camp that thinks it should ;)  You can see this same behavior in
packages like tomboy and beagle as well (although that's no excuse).


Spec URL: http://bjohnson.fedorapeople.org/evolution-python.spec
SRPM URL: http://bjohnson.fedorapeople.org/evolution-python-0.0.4-2.fc7.src.rpm

Review:
+ package builds in mock (development i386).
+ rpmlint is silent for SRPM, But NOT for RPM.
  evolution-python.i386: W: devel-file-in-non-devel-package
/usr/lib/pkgconfig/evolution-python.pc
  ==> We can ignore this for thi spackage instead of creating a -devel for
installing single file.
+ source files match upstream url
2d08555f0a6de288bfcc3b048d98b3e4  evolution-python-0.0.4.tar.gz
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ BuildRequires are proper.
+ Compiler flags used correctly.
+ defattr usage is correct.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code, not content.
+ no headers or static libraries.
+ evolution-python.pc file present.
+ -devel subpackage not needed for single file.
+ no .la files.
+ no translations are available.
+ Does owns the directories it creates.
+ no scriptlets present.
+ no duplicates in %files.
+ file permissions are appropriate.
+ Package evolution-python-0.0.4-2.fc9 ->
  Provides: ebook.so ecal.so
  Requires: libORBit-2.so.0 libbonobo-2.so.0 libbonobo-activation.so.4 libc.so.6
libc.so.6(GLIBC_2.0) libc.so.6(GLIBC_2.1.3) libc.so.6(GLIBC_2.4) libdl.so.2
libebook-1.2.so.9 libecal-1.2.so.7 libedataserver-1.2.so.9 libgconf-2.so.4
libgdk_pixbuf-2.0.so.0 libglib-2.0.so.0 libgmodule-2.0.so.0 libgnome-2.so.0
libgobject-2.0.so.0 libgthread-2.0.so.0 libpango-1.0.so.0 libpopt.so.0
libpthread.so.0 librt.so.1 libxml2.so.2 pkgconfig python(abi) = 2.5 rtld(GNU_HASH)
+ Not a GUI App.
APPROVED.

Thanks for the review!

New Package CVS Request
=======================
Package Name: evolution-python
Short Description: Python bindings for manipulating evolution data
Owners: bjohnson
Branches: F-7 F-8
InitialCC:
Cvsextras Commits: yes

cvs done.

Built for F-9, F-8, F-7; pushed to testing...