Bug 38399

Summary: pine 4.33 whitespace breakage
Product: [Retired] Red Hat Linux Reporter: Matt Domsch <matt_domsch>
Component: pineAssignee: Mike A. Harris <mharris>
Status: CLOSED DUPLICATE QA Contact: David Lawrence <dkl>
Severity: medium Docs Contact:
Priority: medium    
Version: 7.1CC: john_hull
Target Milestone: ---   
Target Release: ---   
Hardware: i386   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2001-06-23 21:23:16 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 23679    
Bug Blocks:    
Attachments:
Description Flags
patch-before-pine.gz
none
patch-before-pine.hex
none
patch-after-pine.gz
none
patch-after-pine.hex
none
pine-breakage.diff
none
Same bug, same patch (updated). Please apply. none

Description Matt Domsch 2001-04-30 16:15:45 UTC 
This is a bug report against Pine 4.33 as found in Red Hat Linux 7.1,
pine-4.33-8, running on an i386-based platform.

I've run into strange case where pine, when sending mail, mangles
whitespace, in this case, inside of a patch.  Attached are
several files.  patch-before-pine.gz contains the patch as extracted by
diff -bu (compressed for this message to ensure it says the same, but was
included in the message body as text when sent).  patch-after-pine.gz
contains the patch as exported from pine after being sent/received.

In looking at a diff of the hex dump, you'll see that
\n[space]\n[space*7]\n got merged into \n\n\n.  This causes the
patch, when received, to fail to apply.

-0000150   s   [   3   ]   )   )   ;  \n      \n
-0000160      \n   +                           s   c   s   i   _   s   e
+0000150   s   [   3   ]   )   )   ;  \n  \n  \n   +
+0000160       s   c   s   i   _   s   e   t   _   p   c   i   _   d   e
Comment 1 Matt Domsch 2001-04-30 16:24:40 UTC 
Created attachment 16847 [details]
patch-before-pine.gz
Comment 2 Matt Domsch 2001-04-30 16:25:13 UTC 
Created attachment 16848 [details]
patch-before-pine.hex
Comment 3 Matt Domsch 2001-04-30 16:25:46 UTC 
Created attachment 16849 [details]
patch-after-pine.gz
Comment 4 Matt Domsch 2001-04-30 16:26:15 UTC 
Created attachment 16850 [details]
patch-after-pine.hex
Comment 5 Matt Domsch 2001-04-30 16:26:52 UTC 
Created attachment 16851 [details]
pine-breakage.diff
Comment 6 Mike A. Harris 2001-05-06 05:58:05 UTC 
Hopefully will be fixed in PINE 4.34 or whatever is the next release.
Deferring for next official PINE release. (or patch submission)

Workaround: Send patches as file attachments.  (Yes, I know this p*ss*s
Linus off)  ;o)
Comment 7 Mike A. Harris 2001-05-19 06:59:29 UTC 
Any word back from the pine team on this?  I wish they would open PINE CVS
up to the world so that hotfixes can be pulled from it...
Comment 8 Matt Domsch 2001-05-19 14:28:28 UTC 
No comments at all from either pine list I sent the bug report to.
Comment 9 Mike A. Harris 2001-05-28 21:53:13 UTC 
That's a typical response from closed development projects.  I just updated
our pine package with a pinepgp fix, but I don't suspect another update until
a new release of PINE is available.
Comment 10 David Woodhouse 2001-06-11 22:18:41 UTC 
This looks like a duplicate (and indeed a regression) of Bug #23679, which was
fixed many moons ago in a 7.0 erratum release, IIRC. I haven't yet verified that
the cause is the same gratuitous stripwhitespace() call just before sending the
mail. I suspect it is.
Comment 11 David Woodhouse 2001-06-11 22:58:27 UTC 
Created attachment 20782 [details]
Same bug, same patch (updated). Please apply.
Comment 12 Mike A. Harris 2001-06-23 20:45:45 UTC 

*** This bug has been marked as a duplicate of 23679 ***