Bug 385061
| Summary: | Review Request: swfdec-mozilla - Mozilla/Gecko player Flash plugin | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Brian Pepple <bdpepple> |
| Component: | Package Review | Assignee: | Patrice Dumas <pertusus> |
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | fedora-package-review, notting, pertusus, peter |
| Target Milestone: | --- | Flags: | pertusus:
fedora-review+
kevin: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2007-11-18 20:07:58 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | 385041 | ||
| Bug Blocks: | |||
|
Description
Brian Pepple
2007-11-15 17:30:41 UTC
Potentially stupid question - if you have swfdec-mozilla, gnash-plugin, and flash-plugin all installed simultaneously, what happens? (In reply to comment #1) > Potentially stupid question - if you have swfdec-mozilla, gnash-plugin, and > flash-plugin all installed simultaneously, what happens? Truthfully, I have no idea. Let me do some testing to see what blows up. rpmlint says: swfdec-mozilla.src: W: invalid-license LGPL swfdec-mozilla.i386: W: invalid-license LGPL swfdec-mozilla-debuginfo.i386: W: invalid-license LGPL MAINTAINERS could be in %doc. Isn't firefox-devel obsolete and now xulrunner should be used? Otherwise, the source timestamp isn't kept: -rw-rw-r-- 1 dumas dumas 398977 nov 15 16:49 ../SOURCES/swfdec-mozilla-0.5.4.tar.gz -rw-rw-r-- 1 dumas dumas 398977 nov 15 11:12 swfdec-mozilla-0.5.4.tar.gz Forgot to say that it works fine, and installed together with gnash, in my case, it is swfdec plugin which is used. (In reply to comment #4) > Forgot to say that it works fine, and installed together with gnash, > in my case, it is swfdec plugin which is used. I tested this with the flash-plugin, and swfdec was also used by the browser. Spec URL: http://bpepple.fedorapeople.org/rpms/swfdec-mozilla.spec SRPM URL: http://bpepple.fedorapeople.org/rpms/swfdec-mozilla-0.5.4-1.fc8.src.rpm * Sat Nov 17 2007 Brian Pepple <bpepple> - 0.5.4-2 - Update license tag. - Drop BR on firefox-devel. Oh, here's a link to a scratch build if you want to review the buld logs. http://koji.fedoraproject.org/koji/taskinfo?taskID=247096 * follow packaging guidelines * spec file is legible * free software, license included * match upstream 07fd3b851df6c70eb7f25944aa4990e3 ../SOURCES/swfdec-mozilla-0.5.4.tar.gz * %files section sane Once again I think that MAINTAINERS should be shipped, there is a reference to it in README. Not a blocker. Seems like an internal copy of the firefox headers is used. I think it would be better to use the system headers, but I won't make it a blocker. APPROVED New Package CVS Request ======================= Package Name: swfdec-mozilla Short Description: Mozilla/Gecko player Flash plugin using swfdec Owners: bpepple Cvsextras Commits: yes cvs done. built for devel. Patrice, thanks for the review. |