Bug 388981
| Summary: | Review Request: libnss-mysql - NSS library for MySQL | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Jan ONDREJ <ondrejj> |
| Component: | Package Review | Assignee: | Lubomir Rintel <lkundrak> |
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | fedora-package-review, notting |
| Target Milestone: | --- | Flags: | lkundrak:
fedora-review+
kevin: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2007-12-01 07:06:53 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Jan ONDREJ
2007-11-17 22:55:55 UTC
BuildRoot should be %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u}
-n) (see Packaging/Guidelines#BuildRoot in the wiki)
Mock build fails with:
2007-11-18 02:36:14,268 - util.py:218:DEBUG: checking for MySQL headers...
/usr/include/mysql
2007-11-18 02:36:14,268 - util.py:218:DEBUG: checking for MySQL libraries...
configure: error: Cannot locat
e MySQL libraries. Try using --with-mysql=DIR
2007-11-18 02:36:14,268 - util.py:218:DEBUG: error: Bad exit status from
/var/tmp/rpm-tmp.50035 (%build)
2007-11-18 02:36:14,268 - util.py:218:DEBUG:
2007-11-18 02:36:14,268 - util.py:218:DEBUG:
2007-11-18 02:36:14,268 - util.py:218:DEBUG: RPM build errors:
2007-11-18 02:36:14,268 - util.py:218:DEBUG: Bad exit status from
/var/tmp/rpm-tmp.50035 (%build)
2007-11-18 02:36:14,269 - trace_decorator.py:27:DEBUG: EXCEPTION:
Command(rpmbuild -bb --target x86_64 --no
deps //builddir/build/SPECS/libnss-mysql.spec) failed. See logs for output.
I am sorry, I forgotten to upload my latest src.rpm. Buildroot fixed in 1.5-4 release. New URL's: Spec URL: http://www.salstar.sk/pub/fedora/SPECS/libnss-mysql.spec SRPM URL: http://www.salstar.sk/pub/fedora/SRPMS/8/libnss-mysql-1.5-4.fc8.src.rpm This still fails to build for me. The build problem comes from the configure script only checking for /usr/lib/mysql/ibmysqlclient.*, when on x86_64 the libraries are in /usr/lib64/mysql. Unfortunately due to complete brokenness of the configure script, it is not possible to pass anything which will make it look in the proper location. It will check the following directories: what you pass to --with-mysql /usr /usr/local /usr/local/mysql /opt/local /opt/local/mysql for the following files: lib/mysqlclient.so lib/mysql/libmysqlclient.so lib/libmysqlclient.a lib/mysql/libmysqlclient.a so no matter what you pass, it will never look in /usr/lib64/mysql. Your only options are to patch the configure script, or to impress upon upstream the need to fix this and wait for them to do so. Taking this for the review. http://www.salstar.sk/pub/fedora/SRPMS/8/libnss-mysql-1.5-5.fc8.src.rpm ChangeLog: * Sun Nov 18 2007 Jan ONDREJ (SAL) <ondrejj(at)salstar.sk> - 1.5-5 - added a patch to build on x86_64 and may be other - regenerated autoconf to use added patch - provides cleanup * Please fix your buildroot http://fedoraproject.org/wiki/Packaging/Guidelines#head-b4fdd45fa76cbf54c885ef0836361319ab962473 * This comment makes little sense, please remove it: # These are not required for package functionality, but it may be better # to run ldconfig after modifying /usr/lib content and rpmlint is more # quiet. * Whis is this provide in place? Provides: libnss_mysql = %{version}-%{release} * Just a tip; Isn't the same thing achieved with autoreconf? aclocal && autoconf && automake && autoheader * Please remove the bullets from %description, it might not necessarily look well in GUI tools. Updated: http://www.salstar.sk/pub/fedora/SPECS/libnss-mysql.spec http://www.salstar.sk/pub/fedora/SRPMS/8/libnss-mysql-1.5-6.fc8.src.rpm Is it ok with these modified "bullets"? Or how to specify multiple features in description? I think they are very useful for users who search for a package with these functions. %changelog * Tue Nov 27 2007 Jan ONDREJ (SAL) <ondrejj(at)salstar.sk> - 1.5-6 - updated buildroot according to packaging guidelines - removed comment before ldconfig - removed provides libnss_mysql (compatibility with my old packages) - autoreconf used - description bullets updated Spec file updated on URL above to fix formatting for dump text parsers. All the outstanding issues have been fixed. The package builds fine in mock, rpmlint only complains about the config file ont being world-readable, which is sane, asi it could contain database password. Therefore, the package is APPROVED New Package CVS Request ======================= Package Name: libnss-mysql Short Description: NSS library for MySQL Owners: ondrejj Branches: FC-6 F-7 F-8 EL-4 EL-5 InitialCC: Cvsextras Commits: yes cvs done (except for the FC-6 branch. We no longer allow FC-6 branches). Packages built and releases as testing. Closing this bug. |