Bug 394941
Summary: | Review Request: tpm-tools - TPM management utilities | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Kent Yoder <yoder1> |
Component: | Package Review | Assignee: | Mamoru TASAKA <mtasaka> |
Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
Severity: | medium | Docs Contact: | |
Priority: | low | ||
Version: | rawhide | CC: | ejratl, fedora-package-review, key, mtasaka, notting |
Target Milestone: | --- | Flags: | mtasaka:
fedora-review+
kevin: fedora-cvs+ |
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | Bug Fix | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2008-01-02 16:25:56 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: | |||
Bug Depends On: | 323441, 426152 | ||
Bug Blocks: |
Description
Kent Yoder
2007-11-21 20:53:09 UTC
Would you update your spec file with referring to http://fedoraproject.org/wiki/Packaging/Guidelines and my comments in bug 323441? Latest version up for review is available here: http://trousers.sourceforge.net/fedora_tools_submit2/ Thanks, Kent For 1.3.1-2: * SourceURL - Perhaps the correct one is http://downloads.sourceforge.net/trousers/%{name}-%{version}.tar.gz * Redundant Requires A. "Requires: trousers" is not needed - rpmbuild checks the dependency for libraries. For this package tpm-tools binary rpm requires libtspi.so.1 and this dependency should pull trousers automatically. B. Requires(post/postun): /sbin/ldconfig For this package this is not needed because ------------------------------------------------------------- %post -p /sbin/ldconfig %postun -p /sbin/ldconfig ------------------------------------------------------------- automatically adds these dependencies. ? configure option - (This is a question) Would you explain why you want "--disable-pkcs11-support"? * Directory ownership issue -------------------------------------------------------------- %files devel %{_includedir}/tpm_tools/*.h -------------------------------------------------------------- - This causes -------------------------------------------------------------- [tasaka1@localhost ~]$ LANG=C rpm -qf /usr/include/tpm_tools/ file /usr/include/tpm_tools is not owned by any package -------------------------------------------------------------- (In reply to comment #3) > For 1.3.1-2: > > * SourceURL > - Perhaps the correct one is > http://downloads.sourceforge.net/trousers/%{name}-%{version}.tar.gz Yep, I'll fix. > * Redundant Requires > A. "Requires: trousers" is not needed > - rpmbuild checks the dependency for libraries. For this package > tpm-tools binary rpm requires libtspi.so.1 and this dependency > should pull trousers automatically. ok > B. Requires(post/postun): /sbin/ldconfig > For this package this is not needed because > ------------------------------------------------------------- > %post -p /sbin/ldconfig > %postun -p /sbin/ldconfig > ------------------------------------------------------------- > automatically adds these dependencies. ok > ? configure option > - (This is a question) > Would you explain why you want "--disable-pkcs11-support"? pkcs11 support requires the opencryptoki package, which hasn't been submitted. If at some future time we submit that, we could enable this support. > * Directory ownership issue > -------------------------------------------------------------- > %files devel > %{_includedir}/tpm_tools/*.h > -------------------------------------------------------------- > - This causes > -------------------------------------------------------------- > [tasaka1@localhost ~]$ LANG=C rpm -qf /usr/include/tpm_tools/ > file /usr/include/tpm_tools is not owned by any package > -------------------------------------------------------------- Ok, I'll add /usr/include/tpm_tools as I did in the trousers spec file. Kent Latest re-spin is here: http://trousers.sourceforge.net/fedora_tools_submit3/ Thanks, Kent For 1.3.1-3: * mixed-use-of-spaces-and-tabs rpmlint ------------------------------------------------------ $ rpmlint -I mixed-use-of-spaces-and-tabs mixed-use-of-spaces-and-tabs : The specfile mixes use of spaces and tabs for indentation, which is a cosmetic annoyance. Use either spaces or tabs for indentation, not both. ------------------------------------------------------ * Unneeded BuildRequires - "BuildRequires: autoconf automake libtool" are not needed as this spec file acutally does not use any autotools * Macros in %changelog - When to write macros in %changelog, please use %% to stop macros from being expanded. ------------------------------------------------------- [tasaka1@localhost tpm-tools]$ rpmlint *-3*src*rpm tpm-tools.src:79: W: macro-in-%changelog build tpm-tools.src: W: mixed-use-of-spaces-and-tabs (spaces: line 2, tab: line 12) tpm-tools.src:79: W: macro-in-%changelog build tpm-tools.src: W: mixed-use-of-spaces-and-tabs (spaces: line 2, tab: line 12) ------------------------------------------------------- ? library linking - tpm-tools contains the library libtpm_unseal.so.0, however no binaries in tpm-tools are using this library?? ------------------------------------------------------- $ rpm -ql tpm-tools | grep '/usr/s*bin' | xargs ldd -r | grep -v '^/usr' | sort | uniq | grep tpm_unseal (no returns) ------------------------------------------------------- Thanks Mamoru, latest re-spin is here: http://trousers.sourceforge.net/fedora_tools_submit4/ Kent Also - no apps use the library because its provided for developers... Kent Okay. --------------------------------------------------------- This package (tpm-tools) is APPROVED by me --------------------------------------------------------- ! Note To rebuild this package on koji, you have to rebuild trousers first. On dist-f9 koji tag, it takes ~2 hours to get the rebuilt rpms imported into new buildroot (what I mean is that you will probably have to wait about 2 hours after trousers is rebuilt to rebuild this package). Or you can use "chain build" method. Hi Mamoru, It looks like I need to go open a review request for openCryptoki, then modify the tpm-tools specfile to build the pkcs11 stuff. RHIT#184786 is for submission of openCryptoki, so it should be going through this process too. I'll add a dependency here when the new openCryptoki review request is opened. Kent Hmm, looks like entering a new dependency wipes out the old one. Is there a way to make this bug depend on openCryptoki and trousers? Thanks, Kent Just enter more than one bug number to depend on. Comma separated works fine; space separated probably works as well. Is supporting openCryptoki _definitely_ needed before importing this package into Fedora? If not, please import this package as it is and when openCryptoki review request (if you submit it) is passed modify tpm-tools package. Hi Mamoru, As long as openCryptoki gets in at some point, I'm ok. I'll go ahead and import tpm-tools while the openCryptoki request is in progress... Kent New Package CVS Request ======================= Package Name: tpm-tools Short Description: TPM management utilities Owners: key Branches: F-7 F-8 EL-5 InitialCC: Cvsextras Commits: yes cvs done Please close this bug when rebuild and request on bodhi is done. Closing for now as this is already in devel. Package Change Request ====================== Package Name: tpm-tools Updated Fedora Owners: key,ejratl Ack'd co-maintainership by ejratl. cvs done. |