Bug 395051
| Summary: | Review Request: pyJigdo - Python Based Jigdo | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Jonathan Steffan <jonathansteffan> |
| Component: | Package Review | Assignee: | Stewart Adam <s.adam> |
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | fedora-package-review, notting |
| Target Milestone: | --- | Flags: | tcallawa:
fedora-review+
tcallawa: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2007-12-28 21:20:33 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Jonathan Steffan
2007-11-21 23:42:28 UTC
Spec URL: http://files.pyjigdo.fedoraunity.org/pyjigdo.spec SRPM URL: http://files.pyjigdo.fedoraunity.org/pyjigdo-0.2-2.20071124git.fc8.src.rpm + source files match upstream: fc54cbb4e0df8df21d48ee2b00680a6c3124f0a2 + package meets naming and versioning guidelines. + specfile is properly named, is cleanly written and uses macros consistently. + dist tag is present. + build root is correct. + license field matches the actual license. + license is open source-compatible. GPLv2 License text included in package. + latest version is being packaged. + BuildRequires are proper. + compiler flags are appropriate. + %clean is present. + package installs properly debuginfo package looks complete. - rpmlint is silent. * Two minor errors: pyjigdo.src: W: mixed-use-of-spaces-and-tabs (spaces: line 5, tab: line 5) pyjigdo.src: W: strange-permission pyjigdo.spec 0600 pyjigdo.noarch: E: non-executable-script /usr/lib/python2.5/site-packages/pyjigdo/__init__.py 0644 pyjigdo.noarch: E: zero-length /usr/share/doc/pyjigdo-0.2/NEWS pyjigdo.noarch: W: wrong-file-end-of-line-encoding /usr/share/doc/pyjigdo-0.2/TODO pyjigdo.noarch: E: zero-length /usr/share/doc/pyjigdo-0.2/AUTHORS pyjigdo.noarch: W: incoherent-version-in-changelog 0.2-2 0.2-2.20071127git.fc8 + final provides are sane: config(pyjigdo) = 0.2-2.20071127git.fc8 pyjigdo = 0.2-2.20071127git.fc8 + final requires are sane: /usr/bin/python config(pyjigdo) = 0.2-2.20071127git.fc8 jigdo python(abi) = 2.5 rpmlib(CompressedFileNames) <= 3.0.4-1 rpmlib(PartialHardlinkSets) <= 4.0.4-1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 + no shared libraries are added to the regular linker search paths. + owns the directories it creates. + doesn't own any directories it shouldn't. + no duplicates in %files. + file permissions are appropriate. + no scriptlets present. + code, not content. + documentation is small, so no -docs subpackage is necessary. + %docs are not necessary for the proper functioning of the package. + no headers. + no pkgconfig files. + no libtool .la droppings. + not a GUI app. A Koji (scratch) build is in progress here: http://koji.fedoraproject.org/koji/taskinfo?taskID=262420 Assuming that completes successfully, just the few changes to fix the rpmlint messages are needed. SPEC: http://files.pyjigdo.fedoraunity.org/pyjigdo.spec SRPM: http://files.pyjigdo.fedoraunity.org/pyjigdo-0.2-2.20071211git.fc8.src.rpm Based on changes in -3 (fixed on irc), I approve this package. New Package CVS Request ======================= Package Name: pyjigdo Short Description: pyJigdo - Python based Jigdo Owners: jsteffan kanarip Branches: F-7 F-8 devel InitialCC: Cvsextras Commits: yes Cvsextras Commits: no cvs done. Thanks. |