Bug 396511
| Summary: | Review Request: webcpp - Convert C++ code to HTML | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Michal Fabry <mfabry> |
| Component: | Package Review | Assignee: | Lubomir Rintel <lkundrak> |
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | low | ||
| Version: | rawhide | CC: | fedora-package-review, notting |
| Target Milestone: | --- | Flags: | lkundrak:
fedora-review+
kevin: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2008-03-24 14:55:32 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Michal Fabry
2007-11-23 11:11:47 UTC
Taking this for a review. * Fri Nov 23 2007 <furby fedoraproject.org> - 0.8.4-1 This is incorrect Changelog format, it needs your name, like: * Fri Nov 23 2007 Chrobak Truhlik <furby> - 0.8.4-1 ./configure Any reasons for not using %configure macro? If there are some, please add a comment. %setup -n %{name}-%{version}-src
Setup should be quiet, like:
%setup -qn %{name}-%{version}-src
Group: Utility/TextTools This is not a valid group. Please look into /usr/share/doc/rpm-[0-9]*/GROUPS for a list of valid groups I'd suggest either Development/Tools or Applications/Text Please note that none of current tools use groups anyway Spec file repaired and package rebuilded :) Spec URL: http://michal.fabry.sk/data/fedora/webcpp/webcpp.spec SRPM URL: http://michal.fabry.sk/data/fedora/webcpp/webcpp-0.8.4-2.fc9.src.rpm Wonderful. RPMlint is all silent, and all outstanding issues have been addressed. Builds just fine in mock. APPROVED lkundrak, Are you also interested to sponsor the package submitter? I see that he needs sponsor. you may like to see http://fedoraproject.org/wiki/PackageMaintainers/SponsorProcess Parag: I'd be glad to. thanks. Parag, But Lubomir is not a sponsor. https://admin.fedoraproject.org/accounts/dump-group.cgi?group=cvsextras&role_type=&format=html Can you do it, if possible? (In reply to comment #11) > Parag, > > But Lubomir is not a sponsor. > > > https://admin.fedoraproject.org/accounts/dump-group.cgi?group=cvsextras&role_type=&format=html > > Can you do it, if possible? well, If you ask me for sponsorship then I need to check if package submitter has posted at least few preliminary reviews or not to other's package review requests? So that I will come to know that package submitter is knowing well about packaging. If he has done it already then I will be glad to sponsor him. But I saw he has only single package submission and no preliminary reviews done. So I think he should start doing that. Till then he need to wait from my side. New Package CVS Request ======================= Package Name: webcpp Short Description: Convert C++ code to HTML Owners: furby Branches: F-8 InitialCC: Cvsextras Commits: yes cvs done. Michal: Close this with NEXTRELEASE in case you build the package. |