Bug 396731
| Summary: | Review Request: powerpc-utils - Utilities for PowerPC platforms | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | David Woodhouse <dwmw2> | ||||
| Component: | Package Review | Assignee: | Josh Boyer <jwboyer> | ||||
| Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||
| Severity: | medium | Docs Contact: | |||||
| Priority: | medium | ||||||
| Version: | rawhide | CC: | fedora-package-review, notting, pbrobinson | ||||
| Target Milestone: | --- | Flags: | jwboyer:
fedora-review+
jwboyer: fedora-cvs+ |
||||
| Target Release: | --- | ||||||
| Hardware: | All | ||||||
| OS: | Linux | ||||||
| Whiteboard: | |||||||
| Fixed In Version: | Doc Type: | Bug Fix | |||||
| Doc Text: | Story Points: | --- | |||||
| Clone Of: | Environment: | ||||||
| Last Closed: | 2008-10-11 14:38:53 UTC | Type: | --- | ||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||
| Embargoed: | |||||||
| Attachments: |
|
||||||
|
Description
David Woodhouse
2007-11-23 13:33:44 UTC
Created attachment 270171 [details]
Pass CFLAGS on link
Without the attached patch, I get the following build error on ppc64:
Building cmds files...
CC cmds/nvram.o
LD cmds/nvram
/usr/bin/ld: powerpc:common64 architecture of input file `nvram.o' is
incompatible with powerpc:common output
nvram.o: In function `help':
/home/jwboyer/rpm/BUILD/powerpc-utils-1.0.6/cmds/nvram.c:79: relocation
truncated to fit: R_PPC64_REL24 against `puts'
nvram.o: In function `nvram_find_partition':
/home/jwboyer/rpm/BUILD/powerpc-utils-1.0.6/cmds/nvram.c:726: relocation
truncated to fit: R_PPC64_REL24 against `printf'
/home/jwboyer/rpm/BUILD/powerpc-utils-1.0.6/cmds/nvram.c:733: relocation
truncated to fit: R_PPC64_REL24 against `strncmp'
/home/jwboyer/rpm/BUILD/powerpc-utils-1.0.6/cmds/nvram.c:718: relocation
truncated to fit: R_PPC64_REL24 against `puts'
nvram.o: In function `print_of_config_part':
/home/jwboyer/rpm/BUILD/powerpc-utils-1.0.6/cmds/nvram.c:1211: relocation
truncated to fit: R_PPC64_REL24 against `printf'
/home/jwboyer/rpm/BUILD/powerpc-utils-1.0.6/cmds/nvram.c:1213: relocation
truncated to fit: R_PPC64_REL24 against `putchar'
/home/jwboyer/rpm/BUILD/powerpc-utils-1.0.6/cmds/nvram.c:1212: relocation
truncated to fit: R_PPC64_REL24 against `strlen'
/home/jwboyer/rpm/BUILD/powerpc-utils-1.0.6/cmds/nvram.c:1214: relocation
truncated to fit: R_PPC64_REL24 against `putchar'
/home/jwboyer/rpm/BUILD/powerpc-utils-1.0.6/cmds/nvram.c:1217: relocation
truncated to fit: R_PPC64_REL24 against `puts'
/home/jwboyer/rpm/BUILD/powerpc-utils-1.0.6/cmds/nvram.c:1218: relocation
truncated to fit: R_PPC64_REL24 against `strlen'
/home/jwboyer/rpm/BUILD/powerpc-utils-1.0.6/cmds/nvram.c:1221: additional
relocation overflows omitted from the output
collect2: ld returned 1 exit status
make[1]: *** [nvram] Error 1
make: *** [all] Error 2
error: Bad exit status from /var/tmp/rpm-tmp.81211 (%build)
It should build fine in mock, I believe. We default to -m64 there. This is just one of the many reasons why shipping all the -devel packages for the secondary arch is nonsense. It simply doesn't work. Yes, it builds in mock. Ignore. - Package meets naming and packaging guidelines
- Spec file matches base package name.
- Spec has consistant macro usage.
- Meets Packaging Guidelines.
- License
- License field in spec matches
- License file included in package
- Spec in American English
- Spec is legible.
- Sources match upstream md5sum: 33de4697b9dc36be070ae67d545fd4fe
- BuildRequires correct
- Package has %defattr and permissions on files is good.
- Package has a correct %clean section.
- Package has correct buildroot
%{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
- Package is code or permissible content.
- Packages %doc files don't affect runtime.
- Package compiles and builds on at least one arch.
- Package has no duplicate files in %files.
- Package doesn't own any directories other packages own.
- Package owns all the directories it creates.
- No rpmlint output.
SHOULD Items:
- Should build in mock.
- Should build on all supported archs
- Should function as described.
- Should have sane scriptlets.
- Should have subpackages require base package with fully versioned depend.
- Should have dist tag
- Should package latest version
Approved.
New Package CVS Request ======================= Package Name: powerpc-utils Short Description: Utilities for PowerPC platforms Owners: dwmw2 Branches: F-8 Cvsextras Commits: yes David, has this package been built? If so, this bug can be closed. Closing - in rawhide |