Bug 397741

Summary: Review Request: hyphen-de - hyphenation rules for german
Product: [Fedora] Fedora Reporter: Caolan McNamara <caolanm>
Component: Package ReviewAssignee: Parag AN(पराग) <panemade>
Status: CLOSED RAWHIDE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: fedora-package-review, notting
Target Milestone: ---Flags: panemade: fedora-review+
kevin: fedora-cvs+
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2007-11-26 20:20:59 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Caolan McNamara 2007-11-24 12:21:01 UTC
Spec URL: http://people.redhat.com/caolanm/hyphen/hyphen-de.spec
SRPM URL: http://people.redhat.com/caolanm/hyphen/hyphen-de-0.20060120-1.fc9.src.rpm
Description: hyphenation rules for "hyphen" as used for OOo for breaking lines

Comment 1 Parag AN(पराग) 2007-11-25 03:19:21 UTC
afaics this package is LPGLv2+ licensed. But in SPEC I saw its written as
GPLv2+. Am I missing something to read in that source zip file?

Comment 2 Parag AN(पराग) 2007-11-25 03:19:47 UTC
I mean to say LGPLv2+

Comment 3 Caolan McNamara 2007-11-25 11:45:10 UTC
Nah, you're right, updated to be the right license as...

Spec URL: http://people.redhat.com/caolanm/hyphen/hyphen-de.spec
SRPM URL: http://people.redhat.com/caolanm/hyphen/hyphen-de-0.20060120-2.fc9.src.rpm
Description: hyphenation rules for "hyphen" as used for OOo for breaking lines

Comment 4 Parag AN(पराग) 2007-11-25 12:44:35 UTC
Review:
+ package builds in mock (development i386).
+ rpmlint is silent for SRPM and for RPM.
+ source files match upstream.
20e5b706ee3201aa2741dabca824cd8b hyph_de_DE.zip
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ %doc files present.
+ BuildRequires are proper.
+ defattr usage is correct.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains contents.
+ no static libraries.
+ no .pc file present.
+ no -devel subpackage exists.
+ no .la files.
+ no translations are available.
+ Does owns the directories it creates.
+ no duplicates in %files.
+ file permissions are appropriate.
+ no scriptlets are used.
+ Not a GUI app.
APPROVED.

Comment 5 Caolan McNamara 2007-11-25 14:01:28 UTC
Excellent, that completes the hypenators, thanks a lot.

New Package CVS Request
=======================
Package Name: hunspell-de
Short Description: hyphenation rules for "hyphen" as used for OOo for breaking lines
Owners:  caolanm
Branches: devel
Cvsextras Commits: yes

Comment 6 Kevin Fenzi 2007-11-26 17:34:35 UTC
cvs done.