Bug 398051
Summary: | Review Request: accrete - Accrete is a physical simulation of solar system planet formation | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Marek Mahut <mmahut> |
Component: | Package Review | Assignee: | Parag AN(पराग) <panemade> |
Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | rawhide | CC: | fedora-package-review, notting |
Target Milestone: | --- | Flags: | panemade:
fedora-review+
kevin: fedora-cvs+ |
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | Bug Fix | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2007-11-26 18:25:03 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: |
Description
Marek Mahut
2007-11-24 22:06:28 UTC
only mtrng.c is having BSD like license and other files have no license at all. So I guess there should not be any problem to have this package as Public Domain. Also, I saw you can use Source URL as Source0: http://downloads.sourceforge.net/%{name}/%{name}-%{version}.tar.gz also, Compiler flags not honored. check http://fedoraproject.org/wiki/Packaging/Guidelines#head-8b14098227aebff1cf6188939e9d0877295ac448 rpmlint on SRPM gave accrete.src: W: mixed-use-of-spaces-and-tabs (spaces: line 3, tab: line 1) The specfile mixes use of spaces and tabs for indentation, which is a cosmetic annoyance. Use either spaces or tabs for indentation, not both. Hello Parag, thank you for your comments! All should be fixed, spec file updated. Source RPM: http://mmahut.fedorapeople.org/reviews/accrete/accrete-1.0-2.src.rpm You also don't need to have setup written as %setup -q -n %{name}-%{version} as source file name is same as %{name}-%{version} write it only as %setup -q Review: + package builds in mock (development i386). + rpmlint is silent for SRPM and for RPM. + source files match upstream. a8586ec1682cb9545ea380d78a8e83d1 accrete-1.0.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc files present. + BuildRequires are proper. + Compiler flags are used correctly. + defattr usage is correct. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains contents. + no static libraries. + no .pc file present. + no -devel subpackage exists. + no .la files. + no translations are available. + Does owns the directories it creates. + no duplicates in %files. + file permissions are appropriate. + no scriptlets are used. + Not a GUI app. APPROVED. New Package CVS Request ======================= Package Name: accrete Short Description: Accrete is a physical simulation of solar system planet formation Owners: mmahut Branches: devel Cvsextras Commits: yes cvs done. Upload and build. Thank you Kevin, Thank you Parag. |