Bug 398431
| Summary: | Review Request: libnids - Implementation of an E-component of Network Intrusion Detection System | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Robert Scheck <redhat-bugzilla> |
| Component: | Package Review | Assignee: | Parag AN(पराग) <panemade> |
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | low | Docs Contact: | |
| Priority: | low | ||
| Version: | rawhide | CC: | fedora-package-review, notting, panemade |
| Target Milestone: | --- | Flags: | panemade:
fedora-review+
kevin: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2007-12-03 21:50:19 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 399461 | ||
|
Description
Robert Scheck
2007-11-25 15:59:46 UTC
any reason to only specify .h file in BR and not libpcap-devel? Yes, because /usr/include/pcap.h moved in the past from libpcap to the libpcap-devel package and it is an easy and allowed way to include just the header file to detect the correct package automatically. I know, I could work with conditionals, but, at least from my point of view, both solutions don't give them each anything. And so, I can use the same spec file for EPEL as well without thinking about where the pcap.h is located. (In reply to comment #2) > Yes, because /usr/include/pcap.h moved in the past from libpcap to the > libpcap-devel package and it is an easy and allowed way to include just > the header file to detect the correct package automatically. I know, I > could work with conditionals, but, at least from my point of view, both > solutions don't give them each anything. And so, I can use the same spec > file for EPEL as well without thinking about where the pcap.h is located. Then its ok. Review: + package builds in mock (development i386). + rpmlint is silent for SRPM and for RPM. + source files match upstream url 811b31c7a1c4c96442807913b5eb1c95 libnids-1.22.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + BuildRequires are proper. + Compiler flags used correctly. + defattr usage is correct. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no static libraries. + no .pc file present. + -devel subpackage exists. + no .la files. + no translations are available. + Does owns the directories it creates. + ldconfig scriptlets present. + no duplicates in %files. + file permissions are appropriate. + Package libnids-1.22-1.fc9 -> Provides: libnids.so.1.21 Requires: libc.so.6 libc.so.6(GLIBC_2.0) libc.so.6(GLIBC_2.1) libc.so.6(GLIBC_2.1.3) libc.so.6(GLIBC_2.3) libc.so.6(GLIBC_2.3.4) libc.so.6(GLIBC_2.4) libglib-2.0.so.0 libgthread-2.0.so.0 libnsl.so.1 libpcap.so.0.9 libpthread.so.0 libpthread.so.0(GLIBC_2.0) librt.so.1 + Package libnids-devel-1.22-1.fc9 -> Requires: libnids = 1.22-1.fc9 libnids.so.1.21 + Not a GUI App. SHOULD: 1) According to http://fedoraproject.org/wiki/Packaging/SourceURL#head-e27982f18a3bfd26b5b6ecbee113d2d8f3f006f2 you need to change Source URL. 2) Good to have defattr usage as defattr(-,root,root,-) You can do above at time of cvs import also. APPROVED. Parag, I'll have a look to that before importing it to CVS. New Package CVS Request ======================= Package Name: libnids Short Description: Implementation of an E-component of Network Intrusion Detection System Owners: robert Branches: F-7 F-8 EL-4 EL-5 InitialCC: Cvsextras Commits: no cvs done. 37242 (libnids): Build on target fedora-4-epel succeeded. 37241 (libnids): Build on target fedora-5-epel succeeded. Package: libnids-1.22-3.fc7 Tag: dist-fc7-updates-candidate Status: complete Package: libnids-1.22-3.fc8 Tag: dist-f8-updates-candidate Status: complete Package: libnids-1.22-3.fc9 Tag: dist-f9 Status: complete |