Bug 398701
Summary: | Review Request: gfs-porson-fonts - GFS Porson Greek font | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Nicolas Mailhot <nicolas.mailhot> |
Component: | Package Review | Assignee: | Parag AN(पराग) <panemade> |
Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | rawhide | CC: | fedora-package-review, fonts-bugs, notting |
Target Milestone: | --- | Flags: | panemade:
fedora-review+
kevin: fedora-cvs+ |
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | Bug Fix | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2007-11-27 21:38:12 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: |
Description
Nicolas Mailhot
2007-11-25 20:51:15 UTC
looks correct SRPM is http://nim.fedorapeople.org/gfs-porson-fonts-20060908-2.fc9.src.rpm rpmlint gave me gfs-porson-fonts.noarch: I: checking gfs-porson-fonts.noarch: E: description-line-too-long In England, during the 1790’s, Cambridge University Press decided to procure a Your description lines must not exceed 79 characters. If a line is exceeding this number, cut it to fit in two lines. gfs-porson-fonts.noarch: W: no-version-in-last-changelog The last changelog entry doesn't contain a version. Please insert the version that is coherent with the version of the package and rebuild it. (In reply to comment #1) > looks correct SRPM is > http://nim.fedorapeople.org/gfs-porson-fonts-20060908-2.fc9.src.rpm Yes I fixed a small problem after filing the review request > rpmlint gave me > gfs-porson-fonts.noarch: I: checking > gfs-porson-fonts.noarch: E: description-line-too-long In England, during the > 1790’s, Cambridge University Press decided to procure a > Your description lines must not exceed 79 characters. If a line is exceeding > this number, cut it to fit in two lines. The lines have been resized using the standard "fold" tool. So they are all 80 column max. rpmlint targets a non-standard terminal width, 79 column and I don't believe this width is actually in use anywhere or that any terminal user will actually be inconvenienced if we use the full 80 column. If you really insist I may resize the text but that seems a waste of time to me. > gfs-porson-fonts.noarch: W: no-version-in-last-changelog > The last changelog entry doesn't contain a version. Please insert the > version that is coherent with the version of the package and rebuild it. rpmlint wants to force you to put the version at the end of the first changelog line, however the official approved Fedora changelog format list includes a style where the version is not on this line (http://fedoraproject.org/wiki/Packaging/Guidelines#Changelogs, 3rd style) so rpmlint's warning is bogus I prefer you to fix rpmlint error description-line-too-long. Reason, If this is bogus message then we should have already removed it from rpmlint tool itself but as rpmlint is made to report it as error, good to fix this. Updated version posted at the usual place to cut lines at 79 columns. Note that rpmlint does not know how to count UTF-8 characters, so if it still complains do check in an UTF-8 aware editor he's actually right (he isn't) I agree it was big work for you to ask to fix small issue but still I prefer to follow what rpmlint says till rpmlint tool gives it as Error and not Warning. Dunno, But with updated version I still see gfs-porson-fonts.src: E: description-line-too-long In England, during the 1790’s, Cambridge University Press decided to procure a Otherwise Packaging looks ok. APPROVED. I don't want you to waste your time again now so if you want to fix it then fix at time of cvs import. rpmlint is wrong and does no know how to count UTF-8 properly. I actually cheched the line it tags manually - it's less than 79 columns in UTF-8, which is our default encoding. New Package CVS Request ======================= Package Name: gfs-porson-fonts Short Description: GFS Porson Greek font Owners: nicolas.mailhot Branches: F-7, F-8, devel InitialCC: fedora-fonts-bugs-list Cvsextras Commits: Yes cvs done. |