Bug 398881 (libssh2)
Summary: | Review Request: libssh2 - A library implementing the SSH2 protocol | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Chris Weyl <cweyl> |
Component: | Package Review | Assignee: | Mamoru TASAKA <mtasaka> |
Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | rawhide | CC: | djuran, fedora-package-review, itamar, notting, sindrepb |
Target Milestone: | --- | Flags: | mtasaka:
fedora-review+
kevin: fedora-cvs+ |
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
URL: | http://www.libssh2.org/ | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | Bug Fix | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2007-11-28 01:28:25 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: | |||
Bug Depends On: | |||
Bug Blocks: | 241078 |
Description
Chris Weyl
2007-11-25 23:23:18 UTC
One more thing to update in the post-to-review script... :) SRPM URL: http://fedora.biggerontheinside.net/review/libssh2-0.18-2.fc6.src.rpm SPEC URL: http://fedora.biggerontheinside.net/review/libssh2.spec *** Bug 239279 has been marked as a duplicate of this bug. *** For 0.18-2: * %check - This tarball contains tests/ directory and "make check" seems to execute some test programs. Please create %check section and do some tests in there if possible. * Timestamps - Please add --------------------------------------------------- INSTALL="install -p" --------------------------------------------------- to "make install". While sometimes this does not do anything, usually this method works for keeping timestamps on installed files for recent Makefiles. Updated: SRPM URL: http://fedora.biggerontheinside.net/review/libssh2-0.18-3.fc8.src.rpm SPEC URL: http://fedora.biggerontheinside.net/review/libssh2.spec Well, what I meant is to add 'INSTALL="install -p"' to the option of "make install", i.e. ------------------------------------------------------------ make install DESTDIR=%{buildroot} INSTALL="install -p" ------------------------------------------------------------ Other things are okay. -------------------------------------------------------- This package (libssh2) is APPROVED by me -------------------------------------------------------- (In reply to comment #5) > Well, what I meant is to add 'INSTALL="install -p"' to the option > of "make install", i.e. > > ------------------------------------------------------------ > make install DESTDIR=%{buildroot} INSTALL="install -p" > ------------------------------------------------------------ Gotcha -- changed. :) New Package CVS Request ======================= Package Name: libssh2 Short Description: A library implementing the SSH2 protocol Owners: cweyl Branches: F-7, F-8, devel InitialCC: cvs done Imported and building. Thanks for the review! :) New Package CVS Request ======================= Package Name: libssh2 Short Description: A library implementing the SSH2 protocol Owners: cweyl Branches: F-7, F-8, devel InitialCC: scratch that :) Package Change Request ====================== Package Name: libssh2 New Branches: EL-4 EL-5 Updated Fedora CC: djuran Updated EPEL Owners: djuran As discussed with Chris over email, I will take ownership of EPEL branches for this package hello. also is possible to packge php-pecl-ssh2 ? http://pecl.php.net/package/ssh2 (In reply to comment #13) > hello. > > also is possible to packge php-pecl-ssh2 ? > http://pecl.php.net/package/ssh2 Please submit another review request. Perhaps someone who knows about php much more than me will review it. cvs done. |