Bug 399341
| Summary: | Review Request: Nightfall - Nightfall is an astronomy application for emulation of eclipsing stars | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Marek Mahut <mmahut> |
| Component: | Package Review | Assignee: | Lubomir Rintel <lkundrak> |
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | fedora-package-review, mtasaka, notting |
| Target Milestone: | --- | Flags: | lkundrak:
fedora-review+
tcallawa: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2007-12-27 10:05:10 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Marek Mahut
2007-11-26 11:18:56 UTC
Hm, I'm not sure about the location of icon in gnome menu, any suggestions? Taking this for review. Marek; I'd suggest Astronomy;Science;Education Your suggestion took in count, desktop file updated. Please use $find_lang macro for the locales. nightfall.x86_64: W: file-not-utf8 /usr/share/doc/nightfall-1.62/ChangeLog I'd say this doesn't matter. This is just fine. nightfall-debuginfo.x86_64: E: empty-debuginfo-package Do not let nightfall binary be installed this way: /usr/bin/install -c -s nightfall /var/tmp/nightfall-1.62-1.fc8-root-lkundrak/usr/bin/nightfall Note that install -s strips the binary. Please patch -s away from the Makefile /home/lkundrak/rpmbuild/SOURCES/nightfall.desktop: key "Categories" is a list and does not have a semicolon as trailing character, fixing Source file and spec file updated. Thanks. Please,
-make 'CPPFLAGS=-I/usr/include/gtk-2.0' 'CFLAGS=%{optflags}' %{_smp_mflags}
+make %{_smp_mflags}
As we talked about on IRC. Also,
sed -i 's/INSTALL} -s/INSTALL}/' Makefile
This kind of things is usually achieved via patches.
Also, could you please explain why did you introduce this?
%{_datadir}/*
Do you own all these?
nightfall.x86_64: E: standard-dir-owned-by-package /usr/share/man/man1
nightfall.x86_64: E: standard-dir-owned-by-package /usr/share/man
Houps, fixed. Spec file updated. http://mmahut.fedorapeople.org/reviews/nightfall/nightfall-1.62-2.src.rpm Thanks -- seems like all the outstanding issues were addressed. APPROVED Thanks Mr. Lubomir Zmena, New Package CVS Request ======================= Package Name: nightfall Short Description: Nightfall is an astronomy application for emulation of eclipsing stars Owners: mmahut Branches: F-8 InitialCC: fedora-sig Cvsextras Commits: yes InitialCC: astronomy-sig cvs done. build, thank you! nightfall-1.62-2.fc8 has been pushed to the Fedora 8 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update nightfall' nightfall-1.62-2.fc8 has been pushed to the Fedora 8 stable repository. If problems still persist, please make note of it in this bug report. |