Bug 407781
Summary: | Add fonts SPEC template | ||||||
---|---|---|---|---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Nicolas Mailhot <nicolas.mailhot> | ||||
Component: | rpmdevtools | Assignee: | Ville Skyttä <ville.skytta> | ||||
Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||
Severity: | low | Docs Contact: | |||||
Priority: | low | ||||||
Version: | rawhide | ||||||
Target Milestone: | --- | ||||||
Target Release: | --- | ||||||
Hardware: | All | ||||||
OS: | Linux | ||||||
Whiteboard: | |||||||
Fixed In Version: | Doc Type: | Bug Fix | |||||
Doc Text: | Story Points: | --- | |||||
Clone Of: | Environment: | ||||||
Last Closed: | 2008-04-19 13:02:53 UTC | Type: | --- | ||||
Regression: | --- | Mount Type: | --- | ||||
Documentation: | --- | CRM: | |||||
Verified Versions: | Category: | --- | |||||
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
Cloudforms Team: | --- | Target Upstream Version: | |||||
Embargoed: | |||||||
Bug Depends On: | |||||||
Bug Blocks: | 235705 | ||||||
Attachments: |
|
Description
Nicolas Mailhot
2007-12-02 11:43:20 UTC
Is there a minimized (no need to include all that documentation) plain text version of the template available? What package names should it be hooked to in rpmdev-newspec (I guess *-fonts)? (In reply to comment #1) > Is there a minimized (no need to include all that documentation) plain text > version of the template available? Unfortunately, no. I've thought several times of doing one but always refrained since I was not sure what level of comment was appropriate to keep. The table pastes fine in gedit though, then you only need to remove all the comments and empty lines you don't want. It's pretty fast I've done it several times for my packages > What package names should it be hooked to in rpmdev-newspec (I guess *-fonts)? Right, the template is applicable to *-fonts. It will probably evolve with more stuff such as core fonts support whenever the users of those backends bother to formalise and document their prectices. Are my explanations sufficient or do you need a text template version ? They're sufficient, thanks, I'm on it. Ok, done, please go through it and let me know what you think, check out fedora-rpmdevtools in CVS (/cvs/fedora root). Note that I made some stylistic changes to make it consistent with rest of the rpmdevtools spec templates. Also, I dropped %{archivename} because I think making it a macro isn't really useful in many cases. You can drop the template to /etc/rpmdevtools and the new rpmdev-newspec to /usr/bin to test it. http://cvs.fedoraproject.org/viewcvs/*checkout*/fedora-rpmdevtools/spectemplate-fonts.spec?root=fedora&rev=. http://cvs.fedoraproject.org/viewcvs/*checkout*/fedora-rpmdevtools/rpmdev-newspec?root=fedora&rev=. (In reply to comment #5) > Note that I made some stylistic > changes to make it consistent with rest of the rpmdevtools spec templates. Hey, I liked my style and neither FPC nor FESCO objected to it :p You wouldn't want to kill RPM_BUILD_ROOT in your other templates instead? The only problem-inducing change I see (apart from the less-than-ideal styling) is your removal of the install line for ttf fonts. A lot of packagers will just put a cp back in, or forget to preserve timestamps (and fontconfig uses timestamps to detect if it needs to refresh caches), so keeping an example is very much needed I don't know any font-only upstream that bundles a make install anyway. Please have the wiki page changed to say there is an rpmdevtools template when you're done. It's supposed to be ACL-protected against non FPC/FESCO members like me now Also the -f argument to fc-cache should only be given in rpmdevtools versions targetting releases < F9, as Behdad got the bug that necessitated it fixed in rawhide fontconfig (In reply to comment #6) > You wouldn't want to kill RPM_BUILD_ROOT in your other templates instead? No. > so keeping an example is very much needed Better? http://cvs.fedoraproject.org/viewcvs/fedora-rpmdevtools/spectemplate-fonts.spec?root=fedora&r1=1.1&r2=1.2&makepatch=1&diff_format=h > Please have the wiki page changed to say there is an rpmdevtools template when > you're done. Done. BTW, it's still in the PackagingDrafts area so I suppose there are no ACLs guarding it. (In reply to comment #7) > Also the -f argument to fc-cache should only be given in rpmdevtools versions > targetting releases < F9, as Behdad got the bug that necessitated it fixed in > rawhide fontconfig Is the -f a problem for >= F9 font packages? If not, I say we keep it in the template at the very least until F8 goes EOL. rpmdevtools versions targetting < F9 is not very meaningful because we really want people to not need to fork specfiles for cosmetic reasons and to be able to use whatever distro version suits them best and to be able to use the tools in that distro's rpmdevtools to build packages for all active distro versions (eg. use rawhide rpmdevtools to do EPEL-4 packages (dunno if that's applicable to fonts, but to illustrate)). (In reply to comment #8) > (In reply to comment #6) > > > You wouldn't want to kill RPM_BUILD_ROOT in your other templates instead? > > No. ...but I've added an option for users to get it to emit macro style variables instead of shell style ones to rpmdev-newspec in CVS. (In reply to comment #8) > (In reply to comment #6) > > so keeping an example is very much needed > > Better? > http://cvs.fedoraproject.org/viewcvs/fedora-rpmdevtools/spectemplate-fonts.spec?root=fedora&r1=1.1&r2=1.2&makepatch=1&diff_format=h Good enough I guess > > Please have the wiki page changed to say there is an rpmdevtools template when > > you're done. > > Done. BTW, it's still in the PackagingDrafts area so I suppose there are no > ACLs guarding it. Damn, I probably need to nag f13 and spot again then :( > (In reply to comment #7) > > Also the -f argument to fc-cache should only be given in rpmdevtools versions > > targetting releases < F9, as Behdad got the bug that necessitated it fixed in > > rawhide fontconfig > > Is the -f a problem for >= F9 font packages? I will only cause unecessary processing on updates, and some people object to it, and asked to remove it ASAP. I don't particularly care myself Thanks for your work! Created attachment 287561 [details]
Disttagify -f
Do you think something like this patch would be worth it?
(In reply to comment #11) > Created an attachment (id=287561) [edit] > Disttagify -f > > Do you think something like this patch would be worth it? No :) If there is no way to do it without macros and disttags, I'd rather have everyone use -f than complexify the template that much Ok, no problem. Seems good now |