Bug 408171
| Summary: | Review Request: perl-QWizard - A portable graphical question and answer wizard API | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Wes Hardaker <wjhns174> |
| Component: | Package Review | Assignee: | Jason Tibbitts <j> |
| Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | low | Docs Contact: | |
| Priority: | low | ||
| Version: | rawhide | CC: | fedora-package-review, notting, panemade |
| Target Milestone: | --- | Flags: | j:
fedora-review+
gwync: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2008-01-01 02:53:58 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Wes Hardaker
2007-12-03 01:19:02 UTC
why this patch perl-QWizard-copyright.patch is present in SRPM? Because the original source didn't have a copyright statement, so that patch adds it. The patch will be removed from the srpm when the next release of QWizard happens which will contain the patch in the upstream. This builds OK but doesn't seem to install due to a missing dependency on perl(Chart). perl-Chart doesn't export perl(Chart) and really QWizard is only expecting perl(Chart::Lines) so I changed the spec to point to that instead. Spec URL: http://www.hardakers.net/FE/perl-QWizard.spec SRPM URL: http://www.hardakers.net/FE/perl-QWizard-3.12-2.src.rpm I found the SRPM at http://www.hardakers.net/FE/perl-QWizard-3.12-2.fc8.src.rpm Everything looks good to me. * source files match upstream: f85e3f41c7752d92097b96ac6c4c502ed4e721107d6f4f6906bdd87220c06d5e QWizard-3.12.tar.gz * package meets naming and versioning guidelines. * specfile is properly named, is cleanly written and uses macros consistently. * summary is OK. * description is OK. * dist tag is present. * build root is OK. * license field matches the actual license. * license is open source-compatible. * license text not included upstream. * latest version is being packaged. * BuildRequires are proper. * %clean is present. * package builds in mock (rawhide, x86_64). * package installs properly * rpmlint is silent. * final provides and requires are sane: perl(QWizard) = 3.12 perl(QWizard::API) = 3.12 perl(QWizard::Generator) = 3.12 perl(QWizard::Generator::Best) = 3.12 perl(QWizard::Generator::Gtk2) perl(QWizard::Generator::HTML) = 3.12 perl(QWizard::Generator::HTML::Vertical) = 3.12 perl(QWizard::Generator::ReadLine) = 3.12 perl(QWizard::Generator::Tk) perl(QWizard::Plugins::Bookmarks) = 3.12 perl(QWizard::Plugins::History) = 3.12 perl(QWizard::Storage::Base) = 3.12 perl(QWizard::Storage::CGICookie) = 3.12 perl(QWizard::Storage::CGIParam) = 3.12 perl(QWizard::Storage::File) = 3.12 perl(QWizard::Storage::Memory) = 3.12 perl(QWizard::Storage::SQL) = 3.12 perl-QWizard = 3.12-2.fc9 = perl(:MODULE_COMPAT_5.8.8) perl(AutoLoader) perl(CGI) perl(CGI::Cookie) perl(Chart::Lines) perl(Config) perl(Data::Dumper) perl(Exporter) perl(File::Temp) perl(Glib) perl(Gtk2) perl(IO::File) perl(POSIX) perl(QWizard) perl(QWizard::API) perl(QWizard::Generator) perl(QWizard::Generator::HTML) perl(QWizard::Storage::Base) perl(QWizard::Storage::CGICookie) perl(QWizard::Storage::CGIParam) perl(QWizard::Storage::File) perl(QWizard::Storage::Memory) perl(Term::ReadLine) perl(Tk) perl(Tk::FileSelect) perl(Tk::Pane) perl(Tk::Table) perl(strict) * %check is present and all tests pass: All tests successful. Files=5, Tests=48, 0 wallclock secs ( 0.09 cusr + 0.03 csys = 0.12 CPU) * owns the directories it creates. * doesn't own any directories it shouldn't. * no duplicates in %files. * file permissions are appropriate. * no scriptlets present. * code, not content. * documentation is small, so no -docs subpackage is necessary. * %docs are not necessary for the proper functioning of the package. APPROVED New Package CVS Request ======================= Package Name: perl-QWizard Short Description: A wrapper around Getopt::Long to provide a GUI to applications Owners: hardaker Branches: F-7 F-8 devel InitialCC: Cvsextras Commits: I don't think that's quite the description you want. doh! Never work on two bugs at once. New Package CVS Request ======================= Package Name: perl-QWizard Short Description: A portable graphical question and answer wizard API Owners: hardaker Branches: F-7 F-8 devel InitialCC: Cvsextras Commits: cvs done. APPROVED package is already imported in CVS, therefore closing this review. Package Change Request ====================== Package Name: dnssec-tools New Branches: EL-5 EL-6 Owners: hardaker just adding branches (or should the modern git tag names now be el5 and el6?) Git done (by process-git-requests). Package Change Request ====================== Package Name: dnssec-tools New Branches: el5 el6 Owners: hardaker My last request failed to create the branches in git. So trying again... The original form you used for the branch names was fine; the tool will take either EL-N or elN. The el5 and el6 branches already do exist as verified by git branch -lr, so I'm not sure what else we can do for you. Although I guess it might be slightly less confusing if you could refrain from requesting branches to dnssec-tools in a ticket for perl-QWizard. Ah. Whoops. Cut-n-paste errors. Package Change Request ====================== Package Name: perl-QWizard New Branches: el5 el6 Owners: hardaker Git done (by process-git-requests). Package Change Request ====================== Package Name: perl-QWizard New Branches: el7 Owners: hardaker Git done (by process-git-requests). |