Bug 409281

Summary: Review Request: rmap - Rmap is a package that is able to generate images of the earth from a distance
Product: [Fedora] Fedora Reporter: Marek Mahut <mmahut>
Component: Package ReviewAssignee: Lubomir Rintel <lkundrak>
Status: CLOSED RAWHIDE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: fedora-package-review, notting
Target Milestone: ---Flags: lkundrak: fedora-review+
kevin: fedora-cvs+
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2007-12-06 10:23:52 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Marek Mahut 2007-12-03 20:21:45 UTC
Spec URL:  http://mmahut.fedorapeople.org/reviews/rmap/rmap.spec
SRPM URL:  http://mmahut.fedorapeople.org/reviews/rmap/rmap-1.2-1.src.rpm
Koji build: http://koji.fedoraproject.org/koji/taskinfo?taskID=269588
Description:  Rmap is a package that will allow you to generate
images of the earth from a distance or fairly zoomed in.

Comment 1 Lubomir Kundrak 2007-12-03 20:25:16 UTC
Taking this for a review.

Comment 2 Lubomir Kundrak 2007-12-03 21:29:37 UTC
the SPEC file is cleanly written and sane, package is functional.
rpmlint is all quiet.

Please replace

#make 'CFLAGS=%{optflags}' %{_smp_mflags}
make

with

make %{_smp_mflags}

Comment 3 Marek Mahut 2007-12-03 21:55:55 UTC
Spec file and src rpm updated.


  http://mmahut.fedorapeople.org/reviews/rmap/rmap-1.2-2.src.rpm

Comment 4 Lubomir Kundrak 2007-12-04 07:39:28 UTC
Thanks for a nice package!
All the outstanding issues were fixed.

APPROVED

Comment 5 Marek Mahut 2007-12-04 07:59:17 UTC
New Package CVS Request
=======================
Package Name: rmap
Short Description:Rmap is a package that is able to generate images of the earth
from a distance 
Owners: mmahut
Branches: devel
InitialCC: astronomy-sig (fedora-astronomy-list)
Cvsextras Commits: yes

Comment 6 Kevin Fenzi 2007-12-04 20:05:52 UTC
cvs done.

Comment 7 Marek Mahut 2007-12-06 10:23:52 UTC
Thank you.