Bug 409321
Summary: | RFE: information on blkdevs "formatted" as PVs | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Jeremy Katz <katzj> |
Component: | e2fsprogs | Assignee: | Eric Sandeen <esandeen> |
Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
Severity: | low | Docs Contact: | |
Priority: | low | ||
Version: | rawhide | CC: | kzak, oliver |
Target Milestone: | --- | ||
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | 1.40.7-1 | Doc Type: | Bug Fix |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2008-02-29 16:45:55 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: |
Description
Jeremy Katz
2007-12-03 20:39:45 UTC
Hm, while I can get this hooked up quickly in libblkid, by looking for "LVM2" magic, I met with *very* strong resistance from the lvm folks (well, agk) who said, among other things: <agk_> - no way reimplement detection in that lib (libblkid), and lvm2's lib is not available yet and <agk_> having the LVM2 signature is not definitive So this has scared me off just a bit :) How much worse would it be to shell out and run "pvs" ? I guess that's the one true definitive answer, today. Having the signature is just as definitive as all the other filesystem type detection that's done in libblkid. There's no way we're going to run pvs to determine this. Worst case, we'll just continue to carry http://git.fedoraproject.org/?p=hosted/anaconda.git;a=commitdiff;h=67dd982d2d5b3a07718b79efaa926c092685c083 My bigger concern was the statement that the "LVM2" magic isn't definitive... You know, in the bigger picture, we could use a library that also knows how to wipe all other old signatures; frankly I'm surprised blkid can get it right very often with various old things lying around... I'll still run it by Ted. Sent the patch upstream for review (finally, sorry for the delay...) [root@host]# misc/blkid -c /dev/null /dev/sda2 /dev/sda2: UUID="guOQGdcOE3IafCm0190XkPZTy5fCEanQ" TYPE="lvm2pv" [root@host]# pvs -o pv_name,pv_uuid PV PV UUID /dev/sda2 guOQGd-cOE3-IafC-m019-0XkP-ZTy5-fCEanQ -Eric On its way to rawhide via e2fsprogs-1.40.7-1 From the changelog: Teach blkid to detect LVM2 physical volumes. (Addresses Red Hat Bugzilla: #409321) Just FWIW, I noticed that anaconda isn't using this yet: # FIXME: libblkid doesn't show physical volumes as having a filesystem # so let's sniff for that.(#409321) ... if buf.startswith("HM"): return "physical volume (LVM)" ... We use it but we also have a fallback for older libblkid. Which we can probably remove post-F10 |