Bug 415211

*** Bug 411471 has been marked as a duplicate of this bug. ***

MUST:

X rpmlint must be silent
  $ rpmlint ~/rpmbuild/SRPMS/WebKit-1.0.0-0.2.svn28482.fc8.src.rpm 
  $ rpmlint ~/rpmbuild/RPMS/i386/WebKit-gtk-1.0.0-0.2.svn28482.fc8.i386.rpm 
  WebKit-gtk.i386: W: no-documentation
  $ rpmlint ~/rpmbuild/RPMS/i386/WebKit-gtk-devel-1.0.0-0.2.svn28482.fc8.i386.rpm 
  WebKit-gtk-devel.i386: W: no-documentation
  WebKit-gtk-devel.i386: E: only-non-binary-in-usr-lib
  $ rpmlint ~/rpmbuild/RPMS/i386/WebKit-qt-
  WebKit-qt-1.0.0-0.2.svn28482.fc8.i386.rpm       
WebKit-qt-devel-1.0.0-0.2.svn28482.fc8.i386.rpm
  $ rpmlint ~/rpmbuild/RPMS/i386/WebKit-qt-1.0.0-0.2.svn28482.fc8.i386.rpm 
  WebKit-qt.i386: W: no-documentation
  $ rpmlint ~/rpmbuild/RPMS/i386/WebKit-qt-devel-1.0.0-0.2.svn28482.fc8.i386.rpm 
  WebKit-qt-devel.i386: W: no-documentation
  $ rpmlint ~/rpmbuild/RPMS/i386/WebKit-doc-1.0.0-0.2.svn28482.fc8.i386.rpm 
  $ rpmlint ~/rpmbuild/RPMS/i386/WebKit-debuginfo-1.0.0-0.2.svn28482.fc8.i386.rpm 

  W: no-documentation should be ok, because docs is in doc package.

  E: only-non-binary-in-usr-lib, i am not sure what this means.

* source match upstream
  $ sha1sum ~/rpmbuild/SOURCES/WebKit-r28482.tar.bz2 
  52b8534bff2727ca6cff39ee87d6c41417ec8e1c 
/home/tim/rpmbuild/SOURCES/WebKit-r28482.tar.bz2
  $ sha1sum WebKit-r28482.tar.bz2 
  52b8534bff2727ca6cff39ee87d6c41417ec8e1c  WebKit-r28482.tar.bz2


* package is named appropriately
* it is legal for Fedora to distribute this
* license field matches the actual license.
* license is open source-compatible.
* specfile name matches %{name}
* summary and description fine
* correct buildroot
* %{?dist} is used
* license text included in package and marked with %doc
* package meets FHS (http://www.pathname.com/fhs/)
* changelog format fine 
* Packager tag not used
* Vendor tag not used
* Distribution tag not used
* License used and not Copyright 
* Summary tag does not end in a period
* specfile is legible
* package successfully compiles and builds on at least x86
X make sure lines are <= 80 characters
  PROMBLEM : Some lines are longer than 80 chars.
* specfile written in American English
* doc goes in a -doc sub-package
* /sbin/ldconfig used in packages containing libraries.
* no rpath.
* no a gui app
* header files goes into -devel sub-package.
* *.so goes into -devel sub-package.
* devel package require the base package using a fully versioned dependency
* macros used appropriately and consistently
* no %makeinstall
* install section must begin with rm -rf $RPM_BUILD_ROOT or %{buildroot}
* no locales
* split Requires(pre,post) into two separate lines
* package not relocatable
* package contains code
* package owns all directories and files
* no %files duplicates
X %defattrs present ( %defattr(-, root, root, -))
  PROBLEM : %defattr(-,root,root,-) is missing in qt & qt-devel %files section.
* %clean present
* %doc files do not affect runtime



SHOULD:
* package should include license text in the package and mark it with %doc
* package should build on i386
? package should build in mock
 - I haven't tried, but should not be a problem

I just tried to rebuild on dist-f9, however it failed at least on
ppc.
http://koji.fedoraproject.org/koji/taskinfo?taskID=281420

Be aware, if you choose to include qt(4) support here, it will (likely?) be 
short-lived.  WebKit is slated to be included in qt-4.4 proper.

(In reply to comment #2)
> MUST:
> 
> X rpmlint must be silent
>   E: only-non-binary-in-usr-lib, i am not sure what this means.

This is ignorable, as the devel subpackages contain only the DSO symlink, header
files, and some other build data (such as a pkgconfig file). 

> X make sure lines are <= 80 characters
>   PROMBLEM : Some lines are longer than 80 chars.

Everything that is user-visible is within the 80-char limit; and the only things
that are not are long path names and such whose split would make it even more
messy, which I'd hate to do.


> X %defattrs present ( %defattr(-, root, root, -))
>   PROBLEM : %defattr(-,root,root,-) is missing in qt & qt-devel %files section.

Oopsie; I fixed this in the 0.3 release.



(In reply to comment #3)
> I just tried to rebuild on dist-f9, however it failed at least on
> ppc.
> http://koji.fedoraproject.org/koji/taskinfo?taskID=281420
Gaah, stupid assembly in the spinlocking. Sorry about that. I've added a patch
which forces use of the pthread implementation instead of handcoded ASM. That
seems to have fixed it:
http://koji.fedoraproject.org/koji/taskinfo?taskID=282220(In reply to comment #4)



(In reply to comment #4)
> Be aware, if you choose to include qt(4) support here, it will (likely?) be 
> short-lived.  WebKit is slated to be included in qt-4.4 proper.

Ah, I didn't about its inclusion plan for Qt 4.4; but when that is released, it
should be a simple enough effort to Obsoletes/Provides the WebKit-qt and
WebKit-qt-devel packages for a smooth upgrade. :)


Updated spec: http://pgordon.fedorapeople.org/for-review/WebKit.spec
Updated SRPM:
http://pgordon.fedorapeople.org/for-review/WebKit-1.0.0-0.3.svn28482.fc8.src.rpm

* Thu Dec 06 2007 Peter Gordon <peter> 1.0.0-0.3.svn28482
- Add proper %%defattr line to qt, qt-devel, and doc subpackages.
- Add patch to forcibly build the TCSpinLock code using the pthread
  implementation:
  + TCSpinLock-use-pthread-stubs.patch


Thanks for the review!

Looks good.

APPROVED.

Awesome. Thanks for the swift review!

New Package CVS Request
=======================
Package Name: WebKit
Short Description: Web content engine library
Owners: pgordon
Branches: devel F-8 F-7
InitialCC: (none)
Cvsextras Commits: Yes

Err; forgot to set the fedora-cvs flag. Stupid me.

cvs done.

WebKit-1.0.0-0.3.svn28482.fc7 has been pushed to the Fedora 7 stable repository.  If problems still persist, please make note of it in this bug report.

WebKit-1.0.0-0.3.svn28482.fc8 has been pushed to the Fedora 8 stable repository.  If problems still persist, please make note of it in this bug report.