Bug 415791 (netbsd-iscsi-review)
| Summary: | Review Request: netbsd-iscsi - User-space implementation of iSCSI target from NetBSD project | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Lubomir Kundrak <lkundrak> |
| Component: | Package Review | Assignee: | Marek Mahut <mmahut> |
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | fedora-package-review, notting |
| Target Milestone: | --- | Flags: | mmahut:
fedora-review+
kevin: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2008-02-05 19:29:20 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Lubomir Kundrak
2007-12-07 16:30:34 UTC
I'll need to write the init script as well. SPEC: http://people.redhat.com/lkundrak/SPECS/netbsd-iscsi.spec SRPM: http://people.redhat.com/lkundrak/mock-results/netbsd-iscsi-20071205-2.fc8.x86_64/netbsd-iscsi-20071205-2.fc8.src.rpm mock: http://people.redhat.com/lkundrak/mock-results/netbsd-iscsi-20071205-2.fc8.x86_64/ Manual is now properly encoded, init script is present. Rpmlint is silent. Nobody loves NetBSD iSCSI? *sad panda* + Package is named according to the Package Naming Guidelines.
+ Spec file name must match the base package %{name}, in the format %{name}.spec.
+ Package meets the Packaging Guidelines.
+ Package successfully compiles and builds into binary rpms on at least one
supported architecture.
Tested on: Fedora rawhide
+ Rpmlint output is sane.
+ Buildroot is correct
(%{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n))
+ Package is licensed with an open-source compatible license and meets other
legal requirements as defined in the legal section of Packaging Guidelines.
+ License field in the package spec file matches the actual license.
License type: BSD
+ Spec file is legible and written in American English.
+ Package is not known to require ExcludeArch
+ Package must own all directories that it creates.
+ Package does not contain duplicates in %files.
+ Permissions on files are set properly.
+ Package has a %clean section, which contains rm -rf of the buildroot
+ Package consistently uses macros.
+ File based requires are sane.
APPROVED.
New Package CVS Request ======================= Package Name: netbsd-iscsi Short Description: User-space implementation of iSCSI target from NetBSD project Owners: lkundrak Branches: EL-4 EL-5 F-7 F-8 Cvsextras Commits: yes cvs done. Danke Schon Kevin, Marek. Imported and built. |