Bug 417801

Summary: psmisc build problem
Product: [Fedora] Fedora Reporter: Oliver Falk <oliver>
Component: psmiscAssignee: Tomas Smetana <tsmetana>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: low Docs Contact:
Priority: low    
Version: 8   
Target Milestone: ---   
Target Release: ---   
Hardware: alpha   
OS: Linux   
Whiteboard:
Fixed In Version: 22.6-2.fc8 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2008-01-11 22:29:48 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Oliver Falk 2007-12-10 09:44:30 UTC
Any chance you might have a look at this build log:

http://buildsys.zero42.at/koji/getfile?taskID=75486&name=build.log

peekfd is broken. Compile error:

[oliver@gosa src]$ make peekfd
gcc -DHAVE_CONFIG_H -I. -I..    -Wall -DLOCALEDIR=\"/usr/share/locale\"    -O2
-g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions --param=ssp-buffer-size=4
-mieee -D_GNU_SOURCE -MT peekfd.o -MD -MP -MF .deps/peekfd.Tpo -c -o peekfd.o
peekfd.c
peekfd.c: In function ‘main’:
peekfd.c:210: error: storage size of ‘regs’ isn’t known
peekfd.c:210: warning: unused variable ‘regs’
make: *** [peekfd.o] Error 1

Any ideas? Thx.

Comment 1 Tomas Smetana 2007-12-10 10:06:19 UTC
The peekfd is highly hardware dependent -- it peeks the CPU registers.  I have
created patches that make it compile/run on all the main architectures Fedora
supports -- I didn't realize that there is someone who would try to compile that
thing on Alpha as well.  Sorry.

The easiest solution is to exclude arch for anything not {ix86|x86_64|ppc}. 
It's not that useful application anyway...

Comment 2 Oliver Falk 2007-12-10 10:18:58 UTC
Well, Alpha is in the secondary arch proposal. So everythin will be built :-)

However, can you simple do a %ifarch %ix86 x86_64 ppc for peekfd in %files
section? Then other archs (like s390(x)) will not have a problem as well.

Comment 3 Tomas Smetana 2007-12-10 11:20:57 UTC
There was a little change required in the Makefile.am also.  The testing package
is here:

http://tsmetana.fedorapeople.org/psmisc/psmisc-22.6-2.fc8.src.rpm

I would be thankful if you could test whether it builds correctly and then I'll
commit the changes.

Comment 4 Oliver Falk 2007-12-10 11:46:47 UTC
Nop. That doesn't do the trick, as the man-page still get's installed:
    Installed (but unpackaged) file(s) found:
   /usr/share/man/man1/peekfd.1.gz


Comment 5 Tomas Smetana 2007-12-10 12:03:34 UTC
@#&*$$!...  OK. Uploaded a new package (same place, same name) with 

%ifnarch %ix86 x86_64 ppc
rm -f $RPM_BUILD_ROOT/%{_mandir}/man1/peekfd.1*
%endif

in the %install section.  That should help.

Comment 6 Oliver Falk 2007-12-10 12:16:28 UTC
WorksForMe(tm). :-)

Comment 7 Fedora Update System 2007-12-10 20:45:29 UTC
psmisc-22.6-2.fc8 has been pushed to the Fedora 8 testing repository.  If problems still persist, please make note of it in this bug report.
 If you want to test the update, you can install it with 
 su -c 'yum --enablerepo=updates-testing update psmisc'

Comment 8 Fedora Update System 2008-01-11 22:29:47 UTC
psmisc-22.6-2.fc8 has been pushed to the Fedora 8 stable repository.  If problems still persist, please make note of it in this bug report.