Bug 418471

Summary:	/etc/profile.d/polikt-bash-completion.sh is in the wrong place
Product:	[Fedora] Fedora	Reporter:	Jason Tibbitts <j>
Component:	PolicyKit	Assignee:	David Zeuthen <davidz>
Status:	CLOSED RAWHIDE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	low	Docs Contact:
Priority:	low
Version:	rawhide	CC:	caillon, mclasen, meyering
Target Milestone:	---
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2007-12-18 19:00:06 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Jason Tibbitts 2007-12-10 17:31:08 UTC

When logging in to a rawhide machine, I get:

/etc/profile.d/polkit-bash-completion.sh:121: command not found: complete
/etc/profile.d/polkit-bash-completion.sh:122: command not found: complete

My shell is zsh, which also reads /etc/profile.d/*.sh but has a different
completion mechanism.  I think there's a directory "/etc/bash_completion.d"
where this kind of thing would be more appropriate.

Comment 1 David Zeuthen 2007-12-13 19:32:19 UTC

Maybe it's better to check in the completion script if the shell used is bash (I
think /etc/bash_completion.d is a RH/Fedora-ism)...

Comment 2 Christopher Aillon 2007-12-13 21:06:05 UTC

That might be better for PK upstream, but it seems like if Fedora has this, we
should use it as intended in our distro, and push /etc/bash_completion.d to
bash-completion upstream (is that a dead project? :-()

Comment 3 David Zeuthen 2007-12-18 18:39:17 UTC

*** Bug 426071 has been marked as a duplicate of this bug. ***

Comment 4 David Zeuthen 2007-12-18 19:00:06 UTC

(In reply to comment #1)
> Maybe it's better to check in the completion script if the shell used is bash (I
> think /etc/bash_completion.d is a RH/Fedora-ism)...

In Rawhide now

http://koji.fedoraproject.org/koji/taskinfo?taskID=299182

Comment 5 Jason Tibbitts 2007-12-20 16:12:21 UTC

Yep, definitely fixed for me with the latest rawhide push.

Comment 6 Christopher Aillon 2007-12-20 16:54:19 UTC

Though I still contend we should put this in /etc/bash_completion.d in Fedora. 
This way users can avoid bash completion if they do not want it by uninstalling
the bash-completion package which would then remove the hooks that traverse that
directory.  It seems strange that PolicyKit would be the only thing that would
get completion on certain installs.  Other packages such as PackageKit and
rpmlint already install scripts to /etc/bash_completion.d and it would be great
if we did too.