Bug 419141
| Summary: | Review Request: cellwriter - handwriting input method | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Jeremy Katz <katzj> |
| Component: | Package Review | Assignee: | Parag AN(पराग) <panemade> |
| Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | fedora-package-review, notting |
| Target Milestone: | --- | Flags: | panemade:
fedora-review+
dennis: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2007-12-15 09:10:05 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Jeremy Katz
2007-12-11 02:27:22 UTC
from build.log /var/tmp/cellwriter-1.3.1-1.fc9-root//usr/share/applications/cellwriter.desktop: key "Categories" is a list and does not have a semicolon as trailing character, fixing /var/tmp/cellwriter-1.3.1-1.fc9-root/usr/share/applications/fedora-cellwriter.desktop: error: value "cellwriter.svg" for key "Icon" in group "Desktop Entry" is an icon name with an extension, but there should be no extension as described in the Icon Theme Specification if the value is not an absolute path Error on file "/var/tmp/cellwriter-1.3.1-1.fc9-root//usr/share/applications/cellwriter.desktop": Failed to validate the created desktop file error: Bad exit status from /var/tmp/rpm-tmp.35461 (%install) The error has changed to a warning in the newest version of desktop-file-utils (0.14-2), but I've also sent a patch upstream to get it fixed when he does a new release. And the trailing semi-colon gets added by desktop-file-install I think you can use Source url as http://pub.risujin.org/%{name}/%{name}-%{version}.tar.gz You may want to add gtk-update-icon-cache scriptlet also. Rest looks ok to me. If you patch dekstop file then this package successfully build in mock. All of the above done in -2. http://katzj.fedorapeople.org/review/cellwriter/cellwriter.spec and http://katzj.fedorapeople.org/review/cellwriter/cellwriter-1.3.1-2.fc9.src.rpm Review: + package builds in mock (development i386). + rpmlint is silent for SRPM and RPM. + source files match upstream. 811c221ad070ea389c18feea7819472c cellwriter-1.3.1.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc files present. + BuildRequires are proper. + Compiler flags are honored correctly. + defattr usage is correct. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code. + no static libraries. + no .pc file present. + no -devel subpackage exists. + no .la files. + no translations are available. + Does owns the directories it creates. + no duplicates in %files. + file permissions are appropriate. + gtk-update-icon-cache scriptlets are used. + Desktop file handled correctly. + GUI app. APPROVED. Thanks for the quick review! New Package CVS Request ======================= Package Name: cellwriter Short Description: Handwriting input method Owners: katzj Branches: devel F-8 Cvsextras Commits: yes CVS done Package already built for all requested branches. Therefore, closing this review now. |