Bug 421231

Summary:	Review Request: kde-l10n - Internationalization support for KDE
Product:	[Fedora] Fedora	Reporter:	Than Ngo <than>
Component:	Package Review	Assignee:	Rex Dieter <rdieter>
Status:	CLOSED RAWHIDE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	eng-i18n-bugs, fedora, fedora-package-review, kevin, ltinkl, notting
Target Milestone:	---	Flags:	rdieter: fedora-review+ kevin: fedora-cvs+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2008-02-19 14:59:08 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Than Ngo 2007-12-12 11:35:24 UTC

Spec URL: http://than.fedorapeople.org/kde-l10n.spec
SRPM URL: kde-l10m srpm is huge, cannot be uploaded on fedorapeople
Description: Internationalization support for KDE

Comment 1 Rex Dieter 2007-12-14 18:15:54 UTC

I can review this.

Comment 2 Rex Dieter 2007-12-14 18:21:55 UTC

Initial suggestions (consider these as SHOULD items):

1. Drop Epoch.  It's a new pkg, shouldn't need it.

2. BuildRequires: kdelibs-devel  ->  BuildRequires: kdelibs4-devel

3. Requires: kdelibs >= 6:%{version} -> Requires: kde-filesystem

4. for each subpkg, add
Provides: %{name}-<locale> = %{version}-%{release}

the latter 3 items similar to recent cvs updates to kde-i18n/devel.

Comment 3 Kevin Kofler 2007-12-14 18:59:12 UTC

I'd say the Epoch one is a MUST (unless there's a repository out there which 
has the package with the Epoch), we don't want to inflate epochs for no good 
reason. ;-)

Comment 4 Than Ngo 2007-12-17 11:22:50 UTC

the obove issues have been fixed.

Comment 5 Than Ngo 2007-12-18 11:27:23 UTC

Rex, it's great if you could please review the new kde-l10n.spec file again. 
The above issues are now fixed. Thanks

Comment 6 Wei-Lun Chao 2007-12-20 14:25:56 UTC

%package Chinese-Big5
should be better renamed to
%package Chinese-Traditional

Comment 7 Than Ngo 2007-12-20 14:52:44 UTC

Wei-Lun, it's now fixed in new kde-l10n.spec. Thanks

Comment 8 Rex Dieter 2007-12-31 04:03:06 UTC

Lacking a buildable pkg atm (to be addressed soon, hopefully), everything else
looks good.  APPROVED.

Comment 9 Kevin Kofler 2008-01-08 07:44:58 UTC

New Package CVS Request
=======================
Package Name: kde-l10n
Short Description: Internationalization support for KDE
Owners: than,rdieter,kkofler,ltinkl
Branches:
InitialCC:
Cvsextras Commits: no

Comment 10 Kevin Fenzi 2008-01-08 16:44:51 UTC

cvs done. 

Any particular reason for the cvsextras: no?

Comment 11 Rex Dieter 2008-02-19 14:59:08 UTC

built/included in rawhide now.