Bug 425956
| Summary: | Review Request: ufoai-data - UFO: Alien Invasion data files | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Karel Volný <kvolny> |
| Component: | Package Review | Assignee: | Hans de Goede <hdegoede> |
| Status: | CLOSED CANTFIX | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | fedora-package-review, notting |
| Target Milestone: | --- | ||
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2008-01-07 19:19:42 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 201449, 412001 | ||
|
Description
Karel Volný
2007-12-17 13:02:35 UTC
Doing a full review. Full review done: Must Fix: --------- * Include an empty %build section, not having a build section can cause problems in certain cases (or so I have been told) * Not all content is licensed under the GPL, I'm afraid this means that ufoai atm cannot be included in Fedora, see: http://ufoai.ninex.info/wiki/index.php/License_Issues http://ufoai.ninex.info/wiki/index.php/License Upstream is working on fixing this though, see the currently latest news item at: http://ufoai.sourceforge.net Perhaps you can help them? Should Fix: ----------- * Passing "-n %{name}-%{version}" to %setup is redundant. ping? (In reply to comment #3) > ping? pong, I was on vacation (In reply to comment #2) > Full review done: > Must Fix: > --------- > * Include an empty %build section, not having a build section can cause > problems in certain cases (or so I have been told) it is there, didn't you look at the old revision? - please check: http://www.hajnet.cz/soubory/ufoai/ufoai-data.spec.2.1.1-2 > * Not all content is licensed under the GPL, I'm afraid this means that ufoai > atm cannot be included in Fedora, see: I guess we have to wait (until the next release) ... let's turn to livna (rpmfusion) meanwhile > Should Fix: > ----------- > * Passing "-n %{name}-%{version}" to %setup is redundant. somehow it did not work for me without it, now it works ... I made a new spec revision, but I won't repack the data (srpm) for now; see http://www.hajnet.cz/soubory/ufoai/ufoai-data.spec.2.1.1-3 (In reply to comment #4) > I guess we have to wait (until the next release) ... let's turn to livna > (rpmfusion) meanwhile > Okay, closing this as a dead review then, feel free to reopen or file a new one once the license issues are fixed. I'll also be closing the review for the engine as the guidelines do not allow for a "useless" package to be packaged, basicly the rule is that if a package needs some content to function and is completely not functional without that content it cannot be part of Fedora. (In reply to comment #5) > Okay, closing this as a dead review then, feel free to reopen or file a new one > once the license issues are fixed. ok, we'll see ... |