Bug 426025

Summary:	[PATCH] Make package noarch
Product:	[Fedora] Fedora	Reporter:	Ville Skyttä <ville.skytta>
Component:	mock	Assignee:	David Cantrell <dcantrell>
Status:	CLOSED NEXTRELEASE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	low	Docs Contact:
Priority:	low
Version:	rawhide	CC:	mebrown
Target Milestone:	---	Keywords:	Patch
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2007-12-18 17:10:19 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Ville Skyttä 2007-12-17 20:56:39 UTC

Mock no longer contains any architecture dependent binaries and the only
potentially arch dependent variable (LIBDIR) substitution in Makefile.am is
actually a no-op these days (ditto PKGDATADIR), so mock could be made noarch.

Patches:
http://scop.fedorapeople.org/patches/mock/0003-Clean-up-no-longer-used-mock.py-variable-substitutio.patch
http://scop.fedorapeople.org/patches/mock/0004-Make-noarch.patch

Unrelated while-at-it whitespace pedantry (make likes tabs):
http://scop.fedorapeople.org/patches/mock/0002-Fix-whitespace.patch

Comment 1 Michael E Brown 2007-12-18 01:10:59 UTC

Not yet.

I'm still working through the libselinux LD_PRELOAD we used to have. Once I have
conclusively determined that we no longer need it, then I dont mind going to noarch.

I'm still maintaining a private branch with the libselinux that uses LIBDIR, and
I'm also attempting to share some code between this and a couple other projects,
so I'll not likely apply the Makefile.am patch removing the variable substs.

Will leave this one open until I've decided one way or the other.

Thanks for all of the previous patches you have posted.

Comment 2 Ville Skyttä 2007-12-18 16:42:27 UTC

Ok.  A couple of related comments though:

The LIBDIR var substitution looks currently odd (LIBDIR substituted with 
PKGDATADIR): perl -p -i -e 's|^LIBDIR =.*|PKGDATADIR="$(libdir)"|' $$file

If the package won't be made noarch but will contain no native binaries, the
empty debuginfo package should be disabled with "%define debug_package %{nil}".

Comment 3 Michael E Brown 2007-12-18 16:58:53 UTC

Great comments. Completely overlooked the LIBDIR oddity. fixing. (Thanks)

Will also switch mock to noarch for the time being.

Comment 4 Michael E Brown 2007-12-18 17:10:19 UTC

Applied noarch patch. Applied my own fixups for the whitespace (make only
prefers tabs in rules.) Applied my own fixups for variable subst patch.

As always, your contributions are much appreciated. Thank you.