Bug 426539
| Summary: | Review Request: perl-Test-YAML-Meta - Validation of the META.yml file in a distribution. | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Daniel Berrangé <berrange> |
| Component: | Package Review | Assignee: | Parag AN(पराग) <panemade> |
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | fedora-package-review, notting |
| Target Milestone: | --- | Flags: | panemade:
fedora-review+
j: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2007-12-26 16:16:48 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | 426537 | ||
| Bug Blocks: | 426542 | ||
|
Description
Daniel Berrangé
2007-12-21 21:40:36 UTC
And with the SRPM URL... http://berrange.fedorapeople.org/review/perl-Test-YAML-Meta/perl-Test-YAML-Meta-0.06-1.fc9.src.rpm make test failed at http://koji.fedoraproject.org/koji/taskinfo?taskID=307441 Added in these deps to solve it: BuildRequires: perl(YAML) BuildRequires: perl(YAML::Syck) http://berrange.fedorapeople.org/review/perl-Test-YAML-Meta/perl-Test-YAML-Meta.spec http://berrange.fedorapeople.org/review/perl-Test-YAML-Meta/perl-Test-YAML-Meta-0.06-2.fc9.src.rpm Review: + package builds in mock (rawhide). + rpmlint is silent for SRPM. - rpmlint is NOT silent for RPM. perl-Test-YAML-Meta.noarch: W: file-not-utf8 /usr/share/doc/perl-Test-YAML-Meta-0.06/LICENSE ==>take care to fix this issue while importing this package. + source files match upstream url 2f573f7cc983b6fc6509790e38cb14ed Test-YAML-Meta-0.06.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc is present. + BuildRequires are proper. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no headers or static libraries. + no .pc file present. + no -devel subpackage + no .la files. + no translations are available + Does owns the directories it creates. + no scriptlets present. + no duplicates in %files. + file permissions are appropriate. + make test outputsPERL_DL_NONLAZY=1 /usr/bin/perl "-MExtUtils::Command::MM" "-e" "test_harness(0, 'blib/lib', 'blib/arch')" t/*.t t/01use............ok t/02metafiles......ok t/03metaversion....ok t/04metatester.....ok t/90podtest........ok t/91podcover.......ok t/94metatest.......ok All tests successful. Files=7, Tests=166, 0 wallclock secs ( 0.22 cusr + 0.04 csys = 0.26 CPU) + Package perl-Test-YAML-Meta-0.06-2.fc9 -> Provides: perl(Test::YAML::Meta) = 0.06 perl(Test::YAML::Meta::Version) = 0.06 Requires: perl(:MODULE_COMPAT_5.8.8) perl(Test::Builder) perl(Test::YAML::Meta::Version) perl(Test::YAML::Valid) perl(strict) perl(vars) perl(warnings) SHOULD: Fix rpmlint warning on SRPM before cvs import You can add examples directory to %doc New Package CVS Request ======================= Package Name: perl-Test-YAML-Meta Short Description: Validation of the META.yml file in a distribution Owners: berrange Branches: F-8 InitialCC: Cvsextras Commits: yes cvs done. $ koji latest-pkg dist-f9 perl-Test-YAML-Meta Build Tag Built by ---------------------------------------- -------------------- ---------------- perl-Test-YAML-Meta-0.06-3.fc9 dist-f9 berrange Package Change Request ====================== Package Name: perl-Test-YAML-Meta New Branches: EL-6 Owners: berrange CVS done. |